You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/27 12:49:20 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4957: vmware cks: Guard k8s cluster resize if no root disk size passed
Pearl1594 opened a new pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957
### Description
This PR prevents k8s cluster nodes' root disks from being resized on VMware if root disk size isn't provided.
```
2021-04-27 06:26:28,971 ERROR [c.c.k.c.a.KubernetesClusterActionWorker] (API-Job-Executor-8:ctx-8126598d job-803 ctx-9a6a3ae2) (logid:f9bfd370) Provisioning the master VM failed in the Kubernetes cluster : k8s
com.cloud.exception.InvalidParameterValueException: Going from existing size of 4756340736 to size of 0 would shrink the volume.Need to sign off by supplying the shrinkok parameter with value of true.
at com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:1077)
at com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:192)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
```
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Deployed a Kubernetes cluster without passing any root disk size - and it deployed successfully
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828128648
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828043762
<b>Trillian test result (tid-541)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37829 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4957-t541-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-827603034
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828128753
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828121427
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828504282
<b>Trillian test result (tid-549)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35190 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4957-t549-vmware-65u2.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-827601667
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828129095
@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-827602544
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828121175
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828106863
@Pearl1594 test_scale_vm will need some fixing for vmw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4957: vmware cks: Guard k8s cluster resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-827580563
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828506824
<b>Trillian test result (tid-547)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4957-t547-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 3.41 | test_domain_service_offerings.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-827580967
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4957: vmware cks: Guard k8s cluster root disk resize if no root disk size passed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4957:
URL: https://github.com/apache/cloudstack/pull/4957#issuecomment-828468771
<b>Trillian test result (tid-548)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4957-t548-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org