You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/24 00:00:44 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #14318: [BEAM-12041] Revert "Make beam_fn_api, use_runner_v2, and use_unified_worker all trigger the same behavior in the SDK"

kennknowles commented on a change in pull request #14318:
URL: https://github.com/apache/beam/pull/14318#discussion_r600042151



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -849,7 +849,8 @@ public void translate(CombineGroupedValues transform, TranslationContext context
 
             stepContext.addEncodingInput(fn.getAccumulatorCoder());
 
-            boolean isFnApi = DataflowRunner.useUnifiedWorker(context.getPipelineOptions());
+            List<String> experiments = context.getPipelineOptions().getExperiments();

Review comment:
       Assuming the ULR goes green, I think this piece can be omitted. This got pulled in but is not really related.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org