You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/01 04:12:19 UTC
[GitHub] [apisix] Hazel6869 opened a new pull request, #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Hazel6869 opened a new pull request, #7836:
URL: https://github.com/apache/apisix/pull/7836
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
https://github.com/apache/apisix/issues/7722
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hazel6869 commented on a diff in pull request #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Posted by GitBox <gi...@apache.org>.
Hazel6869 commented on code in PR #7836:
URL: https://github.com/apache/apisix/pull/7836#discussion_r965602587
##########
t/plugin/response-rewrite.t:
##########
@@ -699,3 +699,50 @@ X-A: 127.0.0.1
X-B: from 127.0.0.1 to 127.0.0.1:1980
--- no_error_log
[error]
+
+
+
+=== TEST 25: set empty body
Review Comment:
Are there any relevant examples? We tested and found that the original code would go wrong when running this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #7836:
URL: https://github.com/apache/apisix/pull/7836#issuecomment-1233790257
Could you use `Fixes #7722` in the comment message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hazel6869 commented on a diff in pull request #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Posted by GitBox <gi...@apache.org>.
Hazel6869 commented on code in PR #7836:
URL: https://github.com/apache/apisix/pull/7836#discussion_r965646011
##########
t/plugin/response-rewrite.t:
##########
@@ -699,3 +699,50 @@ X-A: 127.0.0.1
X-B: from 127.0.0.1 to 127.0.0.1:1980
--- no_error_log
[error]
+
+
+
+=== TEST 25: set empty body
Review Comment:
@spacewander hi you can see https://github.com/Hazel6869/apisix/runs/8244062115?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7836:
URL: https://github.com/apache/apisix/pull/7836#discussion_r960255145
##########
t/plugin/response-rewrite.t:
##########
@@ -699,3 +699,50 @@ X-A: 127.0.0.1
X-B: from 127.0.0.1 to 127.0.0.1:1980
--- no_error_log
[error]
+
+
+
+=== TEST 25: set empty body
Review Comment:
I run your test locally, and it can be passed even without newly added modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7836: fix: response-rewrite plugin might cause Apache AIPSIX hanging
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7836:
URL: https://github.com/apache/apisix/pull/7836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org