[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6654: Resolve envoy service name from a different position

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#discussion_r603843927



##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/mx/FieldsHelper.java
##########
@@ -82,7 +85,24 @@ public void init(final InputStream inputStream,
             final StringBuffer serviceNamePattern = new StringBuffer();
             while (m.find()) {
                 final String property = m.group("property");
-                flatBuffersFieldNames.add(Splitter.on('.').omitEmptyStrings().splitToList(property));
+                List<String> tokens = Splitter.on('.').omitEmptyStrings().splitToList(property);

Review comment:
       Just did a quick Google search, replacing the `.` with this delimiter `\.(?=([^"]*"[^"]*")*[^"]*$)` can do the trick, but you can make the call whether to replace it or not




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org