You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/09 07:29:23 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #860: Add
ActiveMQ extension
jamesnetherton opened a new pull request #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860
Fixes #424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #860: Add
ActiveMQ extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860#issuecomment-596381507
Messaging has JMS 2 on the classpath so it potentially leads to false positives when testing. Hence I chose to separate into its own itest module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #860:
Add ActiveMQ extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860#discussion_r389515919
##########
File path: extensions/activemq/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus ActiveMQ"
+description: "Camel Quarkus ActiveMQ Support"
+metadata:
+ keywords:
+ - "camel"
+ - "ActiveMQ"
Review comment:
I think used lower case quite consequently so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #860: Add ActiveMQ
extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860#issuecomment-596381203
Wonder if it could make sense to put this among the messaging it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #860: Add ActiveMQ extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860#discussion_r389521726
##########
File path: extensions/activemq/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus ActiveMQ"
+description: "Camel Quarkus ActiveMQ Support"
+metadata:
+ keywords:
+ - "camel"
+ - "ActiveMQ"
Review comment:
I'll change it in a follow up commit. AFAIK, the keyword search on code.quarkus.io is case insensitive, so it'll still work fine with a mixture of upper & lower case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton merged pull request #860: Add
ActiveMQ extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #860: Add ActiveMQ extension
URL: https://github.com/apache/camel-quarkus/pull/860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services