You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/05 07:16:47 UTC

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers

bisakhmondal commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r606956010



##########
File path: api/cmd/managerapi.go
##########
@@ -99,7 +108,9 @@ func NewManagerAPICommand() *cobra.Command {
 			}
 			if err := store.InitStores(); err != nil {
 				log.Errorf("init stores fail: %w", err)
-				panic(err)
+				fmt.Printf("%s\n", err)

Review comment:
       Oops!😅😂




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org