[PR] riscv/mpfs: Add boilerplate code for SMP [nuttx]

["pussuw (via GitHub)" <gi...@apache.org>]

pussuw opened a new pull request, #14397:
URL: https://github.com/apache/nuttx/pull/14397

   ## Summary
   
   Add boilerplate code for enabling SMP mode for MPFS target.
   
   ## Impact
   
   Add SMP build support for MPFS target. No other target is affected.
   
   ## Testing
   
   Build passes
   Simple MPFS SMP target boots to nsh console
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] riscv/mpfs: Add boilerplate code for SMP [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14397:
URL: https://github.com/apache/nuttx/pull/14397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] riscv/mpfs: Add boilerplate code for SMP [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14397:
URL: https://github.com/apache/nuttx/pull/14397#issuecomment-2421939003

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   **Yes, the PR appears to meet the NuttX requirements.** 
   
   **Here's why:**
   
   * **Summary:** Clearly explains the purpose (add SMP support to MPFS), what part of the code is affected (MPFS target), and how it works (adding boilerplate code).
   * **Impact:**  
       * Accurately identifies the added feature (SMP build support for MPFS). 
       * Addresses all impact areas, indicating no change or describing the specific impact.
   * **Testing:** 
       * Confirms testing on a local setup.
       * Provides basic evidence that the build passes and the system boots. 
   
   **Suggestions for Improvement (to make it even stronger):**
   
   * **Summary:** Consider linking a related NuttX issue if one exists for tracking the feature request or bug.
   * **Testing:**
       * **Specificity:**  Be more specific about the build host and target used for testing (e.g., "Linux, x86_64, GCC 12.2.0",  "sim:qemu-rv32").
       * **Functionality:** Go beyond basic boot testing. Demonstrate that SMP functionality within the MPFS target is working correctly (e.g., running a multi-threaded application that interacts with the filesystem).
       * **Logs (Optional):** While not strictly required in this case, providing relevant snippets of logs (especially around SMP initialization) can be very helpful for reviewers. 
   
   By adding these minor enhancements, the PR would be even stronger and easier for reviewers to assess. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org