You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Bryan Pendleton (JIRA)" <de...@db.apache.org> on 2005/12/29 19:27:04 UTC
[jira] Commented: (DERBY-326) Improve streaming of large objects for network server and client
[ http://issues.apache.org/jira/browse/DERBY-326?page=comments#action_12361391 ]
Bryan Pendleton commented on DERBY-326:
---------------------------------------
It seems as though there are a lot of modified lines in your patch, but many of them appear to be simply indentation/whitespace changes. Is it possible that you could re-run your diff command with the whitespace
changes excluded? Perhaps something like "svn diff --diff-cmd diff -x -uw"? That would make the patch
easier to read and understand, for me. Thanks, bryan
> Improve streaming of large objects for network server and client
> ----------------------------------------------------------------
>
> Key: DERBY-326
> URL: http://issues.apache.org/jira/browse/DERBY-326
> Project: Derby
> Type: Improvement
> Components: Network Client, Performance, Network Server
> Reporter: Kathey Marsden
> Assignee: Tomohito Nakayama
> Attachments: DERBY-326.patch
>
> Currently the stream writing methods in network server and client require a length parameter. This means that we have to get the length of the stream before sending it. For example in network server in EXTDTAInputStream we have to use getString and getbytes() instead of getCharacterStream and getBinaryStream so that we can get the length.
> SQLAM Level 7 provides for the enhanced LOB processing to allow streaming without indicating the length, so, the writeScalarStream methods in
> network server DDMWriter.java and network client Request.java can be changed to not require a length.
> Code inspection of these methods seems to indicate that while the length is never written it is used heavily in generating the DSS. One strange thing is that it appears on error, the stream is padded out to full length with zeros, but an actual exception is never sent. Basically I think perhaps these methods need to be rewritten from scratch based on the spec requirements for lobs.
> After the writeScalarStream methods have been changed, then EXTDAInputStream can be changed to properly stream LOBS. See TODO tags in this file for more info. I am guessing similar optimizations available in the client as well, but am not sure where that code is.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-326) Improve streaming of large objects
for network server and client
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I see.
I didn't noticed there exists formatting change.
I will remove formatting change from the patch using command "svn diff
--diff-cmd diff -x -uw".
Best regards.
Daniel John Debrunner wrote:
>Bryan Pendleton (JIRA) wrote:
>
>
>
>> [ http://issues.apache.org/jira/browse/DERBY-326?page=comments#action_12361391 ]
>>
>>Bryan Pendleton commented on DERBY-326:
>>---------------------------------------
>>
>>It seems as though there are a lot of modified lines in your patch, but many of them appear to be simply indentation/whitespace changes. Is it possible that you could re-run your diff command with the whitespace
>>changes excluded? Perhaps something like "svn diff --diff-cmd diff -x -uw"? That would make the patch
>>easier to read and understand, for me. Thanks, bryan
>>
>>
>
>Or even better, try to remove the formatting changes from the patch.
>
>Such formatting changes can obsure the real changes on the actual
>commit, it's better to separate formatting changes into different
>patches from actual code changes.
>
>Dan.
>
>
>
>
>
--
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
tmnk@apache.org
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
Re: [jira] Commented: (DERBY-326) Improve streaming of large objects
for network server and client
Posted by Daniel John Debrunner <dj...@debrunners.com>.
Bryan Pendleton (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-326?page=comments#action_12361391 ]
>
> Bryan Pendleton commented on DERBY-326:
> ---------------------------------------
>
> It seems as though there are a lot of modified lines in your patch, but many of them appear to be simply indentation/whitespace changes. Is it possible that you could re-run your diff command with the whitespace
> changes excluded? Perhaps something like "svn diff --diff-cmd diff -x -uw"? That would make the patch
> easier to read and understand, for me. Thanks, bryan
Or even better, try to remove the formatting changes from the patch.
Such formatting changes can obsure the real changes on the actual
commit, it's better to separate formatting changes into different
patches from actual code changes.
Dan.