You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "cgivre (via GitHub)" <gi...@apache.org> on 2025/04/30 15:18:55 UTC
[PR] DRILL-8523: Remove Support for Java 8 (drill)
cgivre opened a new pull request, #2987:
URL: https://github.com/apache/drill/pull/2987
# [DRILL-8523](https://issues.apache.org/jira/browse/DRILL-8523): Remove Support for Java 8
## Description
This PR removes the CI actions for Java 8 and effectively ends Drill's support for Java 8. As a consequence of that, Drill no longer supports Hadoop 2. The profile is still in the pom.xml file should anyone want to build Drill for Hadoop 2, but we are no longer running CI with those tests.
This PR also adds CI tests for Java 21.
## Documentation
No user facing changes.
## Testing
Ran existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2076801836
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I think this could go in separately, accompanied by an excplicit decision that running the test suite (even Drill itself?) is unsupported outside of UTC? I personally think things should still basically work on machines in different time zones. I know these don't work today, but maybe it _should_ and what's really wanted is a fix, while this makes the symptoms disappear.
I've got `-Djunit.args="-Duser.timezone=UTC"` in my local `mvn test` invocations in the meantime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077607834
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I've run into this issue before. Do you think the "correct" answer would be to put a global option in the test profile in the `pom.xml` whereby the timezone would be set to UTC for all Drill tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre merged PR #2987:
URL: https://github.com/apache/drill/pull/2987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2076801836
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I think this could go in separately, accompanied by an excplicit decision that running the test suite (even Drill itself?) is unsupported outside of UTC? I personally think things should still basically work on machines in different time zones. I know these don't work today, but maybe it _should_ and what's really wanted is a fix, while this make the symptoms disappear.
I've got `-Djunit.args="-Duser.timezone=UTC"` in my local `mvn test` invocations in the meantime
##########
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java:
##########
@@ -307,26 +288,38 @@ public Class<?> getImplementationClass(
s = s.replace(DrillFileUtils.SEPARATOR_CHAR, '.');
names.add(nextSet.getChild(s));
}
- classLoader.injectByteCode(nextGenerated.dot, result.bytes);
+
+ // Only inject bytecode if not already injected
+ if (!injectedClassNames.contains(nextGenerated.dot)) {
Review Comment:
It's hard to tell from the diff what was broken here before. Was the `namesCompleted` Set not enough to keep track of classes that had already been merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077609088
##########
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java:
##########
@@ -307,26 +288,38 @@ public Class<?> getImplementationClass(
s = s.replace(DrillFileUtils.SEPARATOR_CHAR, '.');
names.add(nextSet.getChild(s));
}
- classLoader.injectByteCode(nextGenerated.dot, result.bytes);
+
+ // Only inject bytecode if not already injected
+ if (!injectedClassNames.contains(nextGenerated.dot)) {
Review Comment:
I'm not sure honestly. It seemed to break when I switched the Java version to 11 in the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077677419
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
Turns out the separate Jira issue is already there: [DRILL-8087](https://issues.apache.org/jira/browse/DRILL-8087).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077730190
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I removed the hack and added a comment to the UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8523: Remove Support for Java 8 (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077669175
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends BaseTestQuery {
private static final String DATAFILE = "cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I think the correct way to do it is to understand if these failing tests are telling us that something is genuinely broken in other time zones. If it is then the tests stay as is and the code gets fixed. Or, perhaps the test code is being dumb about time zones in which case that code gets a fix. Last resort for me would be "sorry it only works in UTC". Whichever it is, I think merits its own issue and PR so that its documented and searchable while in this PR it's a bit concealed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org