You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/05 09:40:33 UTC
Review Request 54368: Added helpers to checkpoint a
'destroy-on-recovery' file for containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54368/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-6718
https://issues.apache.org/jira/browse/MESOS-6718
Repository: mesos
Description
-------
The existence of this file causes the containerizer to mark the
container for destruction after agent restarts. This is currently
useful for DEBUG containers launched by a
`LAUNCH_NESTED_CONTAINER_SESSION` call.
Diffs
-----
src/slave/containerizer/mesos/paths.hpp c0fe2a4ae8d8b6de24ab265d483d3edc11c68a0e
src/slave/containerizer/mesos/paths.cpp e090392ed079993968f8664d89ad6c49eca3f3c4
Diff: https://reviews.apache.org/r/54368/diff/
Testing
-------
Tested in subsequent patch.
Thanks,
Kevin Klues
Re: Review Request 54368: Added helpers to checkpoint a
'destroy-on-recovery' file for containers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54368/#review158246
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 6, 2016, 11:04 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54368/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 11:04 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6718
> https://issues.apache.org/jira/browse/MESOS-6718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The existence of this file causes the containerizer to mark the
> container for destruction after agent restarts. This is currently
> useful for DEBUG containers launched by a
> `LAUNCH_NESTED_CONTAINER_SESSION` call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp dd197f92c39c80d73326a1507ad1850086830e88
> src/slave/containerizer/mesos/paths.cpp c5542873b6a313db2405caf9b3d25fead30ba216
>
> Diff: https://reviews.apache.org/r/54368/diff/
>
>
> Testing
> -------
>
> Tested in subsequent patch.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 54368: Added helpers to checkpoint a
'destroy-on-recovery' file for containers.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54368/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 11:04 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updated to fix patch dependency in chain.
Bugs: MESOS-6718
https://issues.apache.org/jira/browse/MESOS-6718
Repository: mesos
Description
-------
The existence of this file causes the containerizer to mark the
container for destruction after agent restarts. This is currently
useful for DEBUG containers launched by a
`LAUNCH_NESTED_CONTAINER_SESSION` call.
Diffs (updated)
-----
src/slave/containerizer/mesos/paths.hpp dd197f92c39c80d73326a1507ad1850086830e88
src/slave/containerizer/mesos/paths.cpp c5542873b6a313db2405caf9b3d25fead30ba216
Diff: https://reviews.apache.org/r/54368/diff/
Testing
-------
Tested in subsequent patch.
Thanks,
Kevin Klues