You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/30 08:20:59 UTC

[GitHub] [spark] c21 commented on pull request #35068: [SPARK-37770][SQL][FOLLOWUP] Implement putByteArrays for WritableColumnVector

c21 commented on pull request #35068:
URL: https://github.com/apache/spark/pull/35068#issuecomment-1002921088


   I am not against this change, it's an improvement on top of current code anyway. Just want to think twice here as we are adding API method to `WritableColumnVector` which is public.
   
   As we discussed before, just wondering if we change the code path to use constant column vector in the future, won't it render this newly added API not used any more?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org