You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2024/03/05 16:42:48 UTC
[PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
felipecrv opened a new pull request, #40368:
URL: https://github.com/apache/arrow/pull/40368
### Rationale for this change
TODO
### What changes are included in this PR?
TODO
### Are these changes tested?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv closed pull request #40368: [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search
URL: https://github.com/apache/arrow/pull/40368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40368:
URL: https://github.com/apache/arrow/pull/40368#issuecomment-1979193738
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40368:
URL: https://github.com/apache/arrow/pull/40368#issuecomment-1979728558
Thanks for your patience. Conbench analyzed the 7 benchmarking runs that have been run so far on PR commit f09f3b3445eed79539fad885ac2e46d03e1bbb53.
There were 2 benchmark results with an error:
- Pull Request Run on `ursa-i9-9960x` at [2024-03-05 17:27:28Z](https://conbench.ursa.dev/compare/runs/a47f05bda64a4cbaa7b2c8c1114374cd...629b4e780d7941db8970f9983b4094b3/)
- [`csv-read` (Python) with compression=gzip, dataset=nyctaxi_2010-01, output_format=arrow_table, streaming=file](https://conbench.ursa.dev/benchmark-results/065e755da4687b8d800092d3f39d8433)
- [`csv-read` (Python) with compression=gzip, dataset=nyctaxi_2010-01, output_format=arrow_table, streaming=file](https://conbench.ursa.dev/benchmark-results/065e755da53372658000dcac75668f87)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/22317616962) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #40368:
URL: https://github.com/apache/arrow/pull/40368#issuecomment-1979263669
Benchmark runs are scheduled for commit f09f3b3445eed79539fad885ac2e46d03e1bbb53. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #40368:
URL: https://github.com/apache/arrow/pull/40368#issuecomment-1979195349
@ursabot please benchmark C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE][C++] Reduce the number of logical index resolutions that might require a binary search [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #40368:
URL: https://github.com/apache/arrow/pull/40368#issuecomment-1979263466
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org