[GitHub] [superset] john-bodley commented on a change in pull request #19166: fix: time filter should be [start, end)

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #19166:
URL: https://github.com/apache/superset/pull/19166#discussion_r828498881



##########
File path: superset/connectors/sqla/models.py
##########
@@ -308,7 +308,7 @@ def get_time_filter(
         if start_dttm:
             l.append(col >= self.table.text(self.dttm_sql_literal(start_dttm)))
         if end_dttm:
-            l.append(col <= self.table.text(self.dttm_sql_literal(end_dttm)))
+            l.append(col < self.table.text(self.dttm_sql_literal(end_dttm)))

Review comment:
       Yikes! Thanks @zhaoyongjie for catching this. This was exactly what SIP-15 was fixing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org