You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/07/22 03:41:20 UTC
Review Request 23785: fix libev-unbundled.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/
-----------------------------------------------------------
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1172
https://issues.apache.org/jira/browse/MESOS-1172
Repository: mesos-git
Description
-------
In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
This fixes.
Diffs
-----
src/python/setup.py.in b996dfe
Diff: https://reviews.apache.org/r/23785/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23785: fix libev-unbundled.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/#review48396
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 22, 2014, 6:08 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23785/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
>
> This fixes.
>
>
> Diffs
> -----
>
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23785: fix libev-unbundled.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/
-----------------------------------------------------------
(Updated July 22, 2014, 6:08 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1172
https://issues.apache.org/jira/browse/MESOS-1172
Repository: mesos-git
Description
-------
In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
This fixes.
Diffs
-----
src/python/setup.py.in b996dfe
Diff: https://reviews.apache.org/r/23785/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23785: fix libev-unbundled.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote:
> > Have you tested this with a non-standard libev install?
>
> Timothy St. Clair wrote:
> This mod is very small so the logic for prefix would be outside. In thinking about it, I could roll this a full prefix check and compile check for -DEV_CHILD_ENABLE. Does this make more sense, then it should address *.
sgtm. can you open a ticket for the proper fix for libev installed in a non-standard location so we can track it?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/#review48374
-----------------------------------------------------------
On July 22, 2014, 6:08 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23785/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
>
> This fixes.
>
>
> Diffs
> -----
>
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23785: fix libev-unbundled.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote:
> > Have you tested this with a non-standard libev install?
>
> Timothy St. Clair wrote:
> This mod is very small so the logic for prefix would be outside. In thinking about it, I could roll this a full prefix check and compile check for -DEV_CHILD_ENABLE. Does this make more sense, then it should address *.
>
> Vinod Kone wrote:
> sgtm. can you open a ticket for the proper fix for libev installed in a non-standard location so we can track it?
https://issues.apache.org/jira/browse/MESOS-1602
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/#review48374
-----------------------------------------------------------
On July 22, 2014, 6:08 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23785/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
>
> This fixes.
>
>
> Diffs
> -----
>
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23785: fix libev-unbundled.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 22, 2014, 4:56 p.m., Vinod Kone wrote:
> > Have you tested this with a non-standard libev install?
This mod is very small so the logic for prefix would be outside. In thinking about it, I could roll this a full prefix check and compile check for -DEV_CHILD_ENABLE. Does this make more sense, then it should address *.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/#review48374
-----------------------------------------------------------
On July 22, 2014, 6:08 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23785/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
>
> This fixes.
>
>
> Diffs
> -----
>
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23785: fix libev-unbundled.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23785/#review48374
-----------------------------------------------------------
Have you tested this with a non-standard libev install?
- Vinod Kone
On July 22, 2014, 1:41 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23785/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 1:41 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In preparing my protobuf patch I realized that the previous libev.patch was missing a cherry-pick.
>
> This fixes.
>
>
> Diffs
> -----
>
> src/python/setup.py.in b996dfe
>
> Diff: https://reviews.apache.org/r/23785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>