You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/01 16:40:43 UTC

[GitHub] [incubator-nuttx] sonicyang opened a new pull request #411: Flat address x86_64 port of Nuttx

sonicyang opened a new pull request #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411
 
 
   This is a flat address mode port of Nuttx to x86_64.
   It consists the following features:
    * Runs in x86_64 long mode.
    * Configurable SSE/AVX support.
    * IRQs are managed by LAPIC(X2APIC) and IOAPIC.
    * Used TSC_DEADLINE or APIC timer for systick.
    * Pages are now maps the kernel at 4GB~, but changeable.
   
   This kernel with ostest have been tested with 
    * Qemu/KVM on a Xeon 2630v4 machine.
    * Bochs with broadwell_ult emulation.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#discussion_r386122861

##########
File path: arch/x86_64/include/arch.h
##########
@@ -0,0 +1,92 @@
+/****************************************************************************
+ * arch/x86_64/include/arch.h
+ *
+ * Copyright (C) 2011 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
@sonicyang All new files added to the repository must have have Apache 2.0 headers with no copyright or author information. you can copy the header from sched/sched/sched_getcpu.c for example.

For those files that have my copyright on them, I do grant you permission to change the license to the Apache 2.0 license.

Sorry but those are Apache rules: All new files must have the Apache 2.0 license. Older files will eventually be converted to Apache 2.0 license as well, but that will require more time.

In general, the code looks good. Have you ran tools/nxstyle against it? No code can come into the repositories that does not meet the NuttX coding standard. The nxstyle program will do some basic checks for conformance to the codeing standard.

If you do those two things, I will be happy to merge the code into the repository.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

patacongo merged pull request #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] sonicyang commented on issue #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

sonicyang commented on issue #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594219500
 
 
   @patacongo 
   Sorry, I am moving to another city this week.
   I won't get a reliable network connection and workable environment until this weekend.
   Yes, Please help me change these, otherwise we have to wait a till the weekend.
   I would be glad to see it merged soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-593985127
 
 
   @sonicyang with your permission, I could also help you to change the license headers.  The code looks good and I would liked to see this merged.  But we need to get Apache 2.0 licenses on the code before it can come into the repositories.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594223969
 
 
   Yes, I can make the changes in the licensing for you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] sonicyang edited a comment on issue #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

sonicyang edited a comment on issue #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594219500
 
 
   @patacongo 
   Sorry, I am moving to another city this week.
   I won't get a reliable network connection and workable environment until this weekend.
   Yes, Please help me change these, otherwise we have to wait till the weekend.
   I would be glad to see it merged soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #411: Flat address x86_64 port of Nuttx

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #411: Flat address x86_64 port of Nuttx
URL: https://github.com/apache/incubator-nuttx/pull/411#discussion_r386123106

Review comment:
This is a large change and difficult to review online. Once you complete the above changes, I will merge to a branch were I can do a more thorough review. Assume there are additional issues, I will then merge that branch to master.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services