You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/02 01:16:14 UTC
[GitHub] [incubator-superset] optiona1 opened a new pull request #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
optiona1 opened a new pull request #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
URL: https://github.com/apache/incubator-superset/pull/8908
…AppInitializer
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
URL: https://github.com/apache/incubator-superset/pull/8908#issuecomment-570304687
Thanks for fixing this @optiona1 . You need to run `black` to fix formatting. I also restarted the `sqlite` CI job, seems like it failed without any reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] optiona1 commented on issue #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
Posted by GitBox <gi...@apache.org>.
optiona1 commented on issue #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
URL: https://github.com/apache/incubator-superset/pull/8908#issuecomment-570437438
ok, it's fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #8908: [Fix],Correct read in Jinja configuration and update docs of Superset…
URL: https://github.com/apache/incubator-superset/pull/8908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org