You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2022/02/10 08:47:00 UTC
[jira] [Updated] (HDDS-6291) Do not let slf4j-log4j12 leak into Ozone FS shaded jar
[ https://issues.apache.org/jira/browse/HDDS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Doroszlai updated HDDS-6291:
-----------------------------------
Summary: Do not let slf4j-log4j12 leak into Ozone FS shaded jar (was: Ozone Client dependency on slf4j-log4j12 inadvertently changed from test to compile)
> Do not let slf4j-log4j12 leak into Ozone FS shaded jar
> ------------------------------------------------------
>
> Key: HDDS-6291
> URL: https://issues.apache.org/jira/browse/HDDS-6291
> Project: Apache Ozone
> Issue Type: Bug
> Components: build, Ozone Client
> Affects Versions: 1.3.0
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Critical
> Labels: pull-request-available
>
> The following commit accidentally changed Ozone Client's dependency on {{slf4j-log4j12}} from {{test}} to {{compile}} scope.
> {code}
> commit 9644f83c0ab86946e4f0f30ab6dadb222f000ebc
> Author: Wei-Chiu Chuang <we...@apache.org>
> AuthorDate: Mon Jan 10 09:02:57 2022 +0800
> Commit: GitHub <no...@github.com>
> CommitDate: Mon Jan 10 09:02:57 2022 +0800
> HDDS-6086. Compute MD5MD5CRC file checksum using chunk checksums from DataNodes (#2919)
> diff --git hadoop-ozone/client/pom.xml hadoop-ozone/client/pom.xml
> index f7cbd5597..b5ba8e7e5 100644
> --- hadoop-ozone/client/pom.xml
> +++ hadoop-ozone/client/pom.xml
> @@ -51,6 +51,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-log4j12</artifactId>
> + </dependency>
> + <dependency>
> + <groupId>org.mockito</groupId>
> + <artifactId>mockito-core</artifactId>
> <scope>test</scope>
> </dependency>
> </dependencies>
> {code}
> Since this is a new dependency, it is silently added into the Ozone FS shaded jars:
> {code}
> [INFO] --- maven-shade-plugin:3.2.4:shade (default) @ ozone-filesystem-shaded ---
> ...
> [INFO] Including org.slf4j:slf4j-log4j12:jar:1.7.30 in the shaded jar.
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org