[GitHub] [ignite-3] ptupitsyn commented on pull request #282: IGNITE-15253 Tuple API improvement

[GitBox <gi...@apache.org>]

ptupitsyn commented on pull request #282:
URL: https://github.com/apache/ignite-3/pull/282#issuecomment-905648077


   @AMashenkov 
   
   > Should TupleImpl be a part of public API or moved to internal package (core module)
   
   I think it should be internal. `Tuple.create` is enough for the public API.
   
   > Do we really need mutable tuple for a row (or for a key at least)?
   
   Why not? It gives more flexibility to the user.
   
   > SchemaAware interface on mutable tuple looks confusing.
   > On the one hand mutable tuple become NOT schema-aware after the first mutation.
   > On the other hand, schema awareness is very useful for client protocol and I can't imagine a case when > we need to mutate Tuple with a Row internally.
   > With the builder approach it was easy to distinct mutable tuple from a schema-aware one (with a row underneath),
   > but for now we need an additional wrapper/object to address this issue.
   
   I think `SchemeAware` is fine. It is an internal interface, and we know that it can be used when tuple is not modified.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org