You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/11 14:18:31 UTC
[I] [Bug] AlertService createRule and updateRule don't validate rule name is not blank [rocketmq-dashboard]
tju-yxq opened a new issue, #1820:
URL: https://github.com/apache/rocketmq-dashboard/issues/1820
AlertService.createRule and updateRule accept AlertRuleVO with null or blank name without validation. The AlertRuleRequestDTO has @NotBlank on name, but the service layer doesn't validate, so direct callers could create rules with null names. This produces invalid Prometheus alert names (falling back to 'RocketMQAlert' for all rules, causing duplicates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] AlertService should validate rule names at the service boundary [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq closed issue #1820: [Bug] AlertService should validate rule names at the service boundary
URL: https://github.com/apache/rocketmq-dashboard/issues/1820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] AlertService createRule and updateRule don't validate rule name is not blank [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on issue #1820:
URL: https://github.com/apache/rocketmq-dashboard/issues/1820#issuecomment-5269612091
I updated the PR with focused regression tests and narrowed the issue text to the behavior that was actually verified.
Verification performed:
```bash
mvn -DskipTests=false "-Dtest=AlertServiceTest#createRuleShouldRejectBlankName+updateRuleShouldRejectBlankNameBeforeRepositoryUpdate" test
```
Result: `BUILD SUCCESS`; `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0`.
This is best described as service-boundary validation hardening. The normal controller DTO path already validates the field, and the issue text has been adjusted to avoid overstating unverified UI/Prometheus consequences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org