You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/04 23:50:38 UTC
[GitHub] [activemq] lucastetreault opened a new pull request #755: Unit tests for AMQ-8053
lucastetreault opened a new pull request #755:
URL: https://github.com/apache/activemq/pull/755
Add some unit tests for https://issues.apache.org/jira/browse/AMQ-8053.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] lucastetreault closed pull request #755: Unit tests for AMQ-8053
Posted by GitBox <gi...@apache.org>.
lucastetreault closed pull request #755:
URL: https://github.com/apache/activemq/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] lucastetreault commented on pull request #755: Unit tests for AMQ-8053
Posted by GitBox <gi...@apache.org>.
lucastetreault commented on pull request #755:
URL: https://github.com/apache/activemq/pull/755#issuecomment-1030892740
¯\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on pull request #755: Unit tests for AMQ-8053
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #755:
URL: https://github.com/apache/activemq/pull/755#issuecomment-1030766712
Are you sure about this test ? At first glance, it doesn't seem fully correct to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #755: Unit tests for AMQ-8053
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #755:
URL: https://github.com/apache/activemq/pull/755#issuecomment-1030891345
@lucastetreault appreciate the PR work here =). However, given it is my change, I need to do the tests.
New PR [758](https://github.com/apache/activemq/pull/758) re-uses network connector test framework and puts the unit tests in activemq-unit-tests instead of activemq-broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] lucastetreault commented on pull request #755: Unit tests for AMQ-8053
Posted by GitBox <gi...@apache.org>.
lucastetreault commented on pull request #755:
URL: https://github.com/apache/activemq/pull/755#issuecomment-1030861291
Any specific concerns? The first two demonstrate the existing functionality and the 3rd shows the change to not override it when the message goes through a network of brokers. Seems correct to me 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org