[GitHub] SavtechSolutions commented on a change in pull request #3227: NIFI-5909 PutElasticsearchHttpRecord doesn't allow to customize the timestamp format

[GitBox <gi...@apache.org>]

SavtechSolutions commented on a change in pull request #3227: NIFI-5909 PutElasticsearchHttpRecord doesn't allow to customize the timestamp format
URL: https://github.com/apache/nifi/pull/3227#discussion_r246458971
 
 

 ##########
 File path: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ##########
 @@ -178,6 +178,36 @@
             .required(true)
             .build();
 
+    static final PropertyDescriptor DATE_FORMAT = new PropertyDescriptor.Builder()
+            .name("put-es-record-date-format")
+            .displayName("Date Format")
+            .description("Custom date format to use when converting fields of date type " +
 
 Review comment:
   Just to confirm, by "reusing" you mean copying what's in DateTimeUtils into my PDs, not to reference existing PDs? They do share a lot of common, but have different fallback values (millisecond longs in CSV vs RecordFieldType.*.getDefaultFormat() for ES), so I don't think I can simply reference the existing PDs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services