You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/03/14 09:35:26 UTC
[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #214: Fix flaky testAcknowledgeCumulativeWithPartition
BewareMyPower opened a new pull request, #214:
URL: https://github.com/apache/pulsar-client-cpp/pull/214
Fixes https://github.com/apache/pulsar-client-cpp/issues/213
### Motivation
In `ConsumerTest.testAcknowledgeCumulativeWithPartition`, the last two
`MessageId`s are acknowledged because they are treated as the latest two
`MessageId`s of the two partitions. However, this assumption is false
because `MultiTopicsConsumerImpl` does not guarantee receiving messages
in a round robin way. Here is an example output when I added the debug
logs for the `MessageId` received.
```
(519,48,1,-1)
(519,49,1,-1)
(518,48,0,-1)
(518,49,0,-1)
```
We can see the last two `MessageId`s are both from partition 0.
### Modifications
Use an array `latestMsgIds` to record the latest `MessageId` of a given
partition in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #214: Fix flaky testAcknowledgeCumulativeWithPartition
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #214:
URL: https://github.com/apache/pulsar-client-cpp/pull/214#issuecomment-1467737778
This PR is based on https://github.com/apache/pulsar-client-cpp/pull/211 to avoid being affected by the very flaky `ConnectFailTest`, so let's wait #211 is merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #214: Fix flaky testAcknowledgeCumulativeWithPartition
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #214:
URL: https://github.com/apache/pulsar-client-cpp/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org