You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/09/24 09:43:10 UTC
[GitHub] [incubator-inlong] leo65535 opened a new pull request #1588: [INLONG-1587] Fix compile error
leo65535 opened a new pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588
Fixes #1587
### Motivation
When compile under JDK11, it will build failed. And the latest Intellij IDEA internal is jdk11.
```
[ERROR] Failed to execute goal on project sort-core: Could not resolve dependencies for project org.apache.inlong:sort-core:jar:0.11.0-incubating-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.7 at specified path /work/JAVA_WORK/jdk/jdk/../lib/tools.jar -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
```
### Modifications
Exclude hbase dependency.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] timothy65535 commented on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
timothy65535 commented on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927271565
Thanks you all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang edited a comment on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
dockerzhang edited a comment on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927268371
@leo65535 great job.
it's better to use another branch for the next PR, `leo65535:master` is not a good choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927268371
@leo65535 great job.
it's better to use another branch for PR, `leo65535:master` is not a good choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] chantccc commented on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
chantccc commented on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927267868
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927262969
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1588](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a8b809) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/385b2a9a29a4e50fcba7e7e84b3938a7510f9465?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385b2a9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1588 +/- ##
============================================
- Coverage 12.19% 12.19% -0.01%
+ Complexity 1049 1048 -1
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
- Hits 3995 3994 -1
Misses 27995 27995
- Partials 765 766 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/1588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385b2a9...6a8b809](https://codecov.io/gh/apache/incubator-inlong/pull/1588?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] timothy65535 removed a comment on pull request #1588: [INLONG-1587][Sort] Fix compile error
Posted by GitBox <gi...@apache.org>.
timothy65535 removed a comment on pull request #1588:
URL: https://github.com/apache/incubator-inlong/pull/1588#issuecomment-927271565
Thanks you all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org