[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7024: Improvements in compat-tester

[GitBox <gi...@apache.org>]

GSharayu commented on a change in pull request #7024:
URL: https://github.com/apache/incubator-pinot/pull/7024#discussion_r646769921



##########
File path: compatibility-verifier/checkoutAndBuild.sh
##########
@@ -39,12 +44,15 @@ function checkoutAndBuild() {
   targetDir=$2
 
   pushd "$targetDir" || exit 1
-  git init
-  git remote add origin https://github.com/apache/incubator-pinot
-  git pull origin master
-  git checkout $commitHash
-  mvn install package -DskipTests -Pbin-dist
+  git init || exit 1
+  git remote add origin https://github.com/apache/incubator-pinot || exit 1
+  git pull origin master || exit 1
+  # Pull the tag list so that we can check out by tag name
+  git fetch --tags || exit 1
+  git checkout $commitHash || exit 1
+  mvn install package -DskipTests -Pbin-dist || exit 1
   popd || exit 1
+  exit 0

Review comment:
       minor, This is not required ideally




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org