You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "VGalaxies (via GitHub)" <gi...@apache.org> on 2024/02/06 13:07:56 UTC
[PR] chore: improve license header checker confs and pre-check header when verifying [incubator-hugegraph]
VGalaxies opened a new pull request, #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445
subtask of #2435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#discussion_r1482424628
##########
pom.xml:
##########
@@ -179,6 +179,7 @@
<exclude>**/rocksdb-*/**</exclude>
<exclude>**/hbase-*/**</exclude>
<exclude>**/apache-cassandra-*/**</exclude>
+ <exclude>**/pid</exclude>
Review Comment:
fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when verifying [incubator-hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#issuecomment-1929579721
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2445?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3f7dc2a`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/3f7dc2a8b284c35374de03c58f11a02f1330f8ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 66.23% compared to head [(`c592f60`)](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2445?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 52.67%.
> :exclamation: Current head c592f60 differs from pull request most recent head f320ca9. Consider uploading reports for the commit f320ca9 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2445 +/- ##
=============================================
- Coverage 66.23% 52.67% -13.57%
+ Complexity 830 545 -285
=============================================
Files 511 511
Lines 42597 42539 -58
Branches 5942 5919 -23
=============================================
- Hits 28215 22408 -5807
- Misses 11565 17700 +6135
+ Partials 2817 2431 -386
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2445?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#discussion_r1480962391
##########
pom.xml:
##########
@@ -207,6 +208,21 @@
</plugin>
</plugins>
</pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>license-check</id>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ <phase>validate</phase>
Review Comment:
if check-style plugin could also do it (consider reuse it in future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "simon824 (via GitHub)" <gi...@apache.org>.
simon824 merged PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#discussion_r1481526764
##########
pom.xml:
##########
@@ -179,6 +179,7 @@
<exclude>**/rocksdb-*/**</exclude>
<exclude>**/hbase-*/**</exclude>
<exclude>**/apache-cassandra-*/**</exclude>
+ <exclude>**/pid</exclude>
Review Comment:
These files or directories are excluded because validation is performed before using `mvn test`, which may include data generated from previous tests or files generated during server runtime, such as:
```text
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/apache-hugegraph-incubating-1.2.0/bin/pid
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/hugegraph-test/rocksdb-data/graph/m/OPTIONS-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#discussion_r1481526764
##########
pom.xml:
##########
@@ -179,6 +179,7 @@
<exclude>**/rocksdb-*/**</exclude>
<exclude>**/hbase-*/**</exclude>
<exclude>**/apache-cassandra-*/**</exclude>
+ <exclude>**/pid</exclude>
Review Comment:
These files or directories are excluded because validation is performed before using `mvn test`, which may include data generated from previous tests or files generated during server runtime, such as:
```text
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/apache-hugegraph-incubating-1.2.0/bin/pid
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/hugegraph-test/rocksdb-data/graph/m/OPTIONS-000015
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: improve license header checker confs and pre-check header when validating [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2445:
URL: https://github.com/apache/incubator-hugegraph/pull/2445#discussion_r1481179502
##########
pom.xml:
##########
@@ -179,6 +179,7 @@
<exclude>**/rocksdb-*/**</exclude>
<exclude>**/hbase-*/**</exclude>
<exclude>**/apache-cassandra-*/**</exclude>
+ <exclude>**/pid</exclude>
Review Comment:
maybe should exclude the whole generated dir? (ignore the suggestion if it's just a test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org