You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@marvin.apache.org by Wei Chen <we...@apache.org> on 2019/06/19 19:18:14 UTC
Create a new PR for revert history
Hello All,
While waiting for the artifact set up on the sonatype server,
I think we can revert the history of the filename change first.
(which is currently part of the PR#25
https://github.com/apache/incubator-marvin/pull/25)
One reason why we didn't move on with the PR is that I am waiting for the
artifact to decide whether we should also remove the history of 2 bin files.
marvin-engine-server-assembly.jar
<https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/marvin-engine-server-assembly.jar>
python-toolbox.tgz
<https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/python-toolbox.tgz>
After all, I think we all agree that we shouldn't keep the bin file in the
repo to minimize the size of the repo, as we should also clear of the
history of it for faster cloning.
Therefore, I will work out a new PR to remove the history of all rename
files plus these 2 bin files.
Is everyone OK with that?
Best Regards
Wei
Re: Create a new PR for revert history
Posted by Wei Chen <we...@apache.org>.
OK.
In this case, if we push a PR with the history of a file already revert, I
don't think it will affect the git history right?
Best Regards
Wei
On Thu, Jun 20, 2019 at 12:15 AM Luciano Resende <lu...@gmail.com>
wrote:
> Please, no push —force.....
>
> I will try to dig the infra discussion around this, but it might even be
> disabled.
>
> On Wed, Jun 19, 2019 at 21:40 Wei Chen <we...@apache.org> wrote:
>
> > Hello Everyone,
> >
> > On second thought, I think I will merge the PR#25 first.
> > We can handle the bin file history after we are good with the sonatype
> > artifact.
> > If everyone is good with that, I will merge it tomorrow.
> >
> > Best Regards
> > Wei
> >
> > On Wed, Jun 19, 2019 at 2:18 PM Wei Chen <we...@apache.org> wrote:
> >
> > > Hello All,
> > >
> > > While waiting for the artifact set up on the sonatype server,
> > > I think we can revert the history of the filename change first.
> > > (which is currently part of the PR#25
> > > https://github.com/apache/incubator-marvin/pull/25)
> > >
> > > One reason why we didn't move on with the PR is that I am waiting for
> the
> > > artifact to decide whether we should also remove the history of 2 bin
> > files.
> > > marvin-engine-server-assembly.jar
> > > <
> >
> https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/marvin-engine-server-assembly.jar
> > >
> > > python-toolbox.tgz
> > > <
> >
> https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/python-toolbox.tgz
> > >
> > >
> > > After all, I think we all agree that we shouldn't keep the bin file in
> > the
> > > repo to minimize the size of the repo, as we should also clear of the
> > > history of it for faster cloning.
> > >
> > > Therefore, I will work out a new PR to remove the history of all rename
> > > files plus these 2 bin files.
> > >
> > > Is everyone OK with that?
> > >
> > > Best Regards
> > > Wei
> > >
> >
> --
> Sent from my Mobile device
>
Re: Create a new PR for revert history
Posted by Luciano Resende <lu...@gmail.com>.
Please, no push —force.....
I will try to dig the infra discussion around this, but it might even be
disabled.
On Wed, Jun 19, 2019 at 21:40 Wei Chen <we...@apache.org> wrote:
> Hello Everyone,
>
> On second thought, I think I will merge the PR#25 first.
> We can handle the bin file history after we are good with the sonatype
> artifact.
> If everyone is good with that, I will merge it tomorrow.
>
> Best Regards
> Wei
>
> On Wed, Jun 19, 2019 at 2:18 PM Wei Chen <we...@apache.org> wrote:
>
> > Hello All,
> >
> > While waiting for the artifact set up on the sonatype server,
> > I think we can revert the history of the filename change first.
> > (which is currently part of the PR#25
> > https://github.com/apache/incubator-marvin/pull/25)
> >
> > One reason why we didn't move on with the PR is that I am waiting for the
> > artifact to decide whether we should also remove the history of 2 bin
> files.
> > marvin-engine-server-assembly.jar
> > <
> https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/marvin-engine-server-assembly.jar
> >
> > python-toolbox.tgz
> > <
> https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/python-toolbox.tgz
> >
> >
> > After all, I think we all agree that we shouldn't keep the bin file in
> the
> > repo to minimize the size of the repo, as we should also clear of the
> > history of it for faster cloning.
> >
> > Therefore, I will work out a new PR to remove the history of all rename
> > files plus these 2 bin files.
> >
> > Is everyone OK with that?
> >
> > Best Regards
> > Wei
> >
>
--
Sent from my Mobile device
Re: Create a new PR for revert history
Posted by Wei Chen <we...@apache.org>.
Hello Everyone,
On second thought, I think I will merge the PR#25 first.
We can handle the bin file history after we are good with the sonatype
artifact.
If everyone is good with that, I will merge it tomorrow.
Best Regards
Wei
On Wed, Jun 19, 2019 at 2:18 PM Wei Chen <we...@apache.org> wrote:
> Hello All,
>
> While waiting for the artifact set up on the sonatype server,
> I think we can revert the history of the filename change first.
> (which is currently part of the PR#25
> https://github.com/apache/incubator-marvin/pull/25)
>
> One reason why we didn't move on with the PR is that I am waiting for the
> artifact to decide whether we should also remove the history of 2 bin files.
> marvin-engine-server-assembly.jar
> <https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/marvin-engine-server-assembly.jar>
> python-toolbox.tgz
> <https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/python-toolbox.tgz>
>
> After all, I think we all agree that we shouldn't keep the bin file in the
> repo to minimize the size of the repo, as we should also clear of the
> history of it for faster cloning.
>
> Therefore, I will work out a new PR to remove the history of all rename
> files plus these 2 bin files.
>
> Is everyone OK with that?
>
> Best Regards
> Wei
>