You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/07 06:51:45 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request #11189: fix mysql select cast(a as signed)
tuichenchuxin opened a new pull request #11189:
URL: https://github.com/apache/shardingsphere/pull/11189
Fixes #11168
Changes proposed in this pull request:
- add support for select cast signed/unsigned
- add test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #11189: fix mysql select cast(a as signed)
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #11189:
URL: https://github.com/apache/shardingsphere/pull/11189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #11189: fix mysql select cast(a as signed)
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #11189:
URL: https://github.com/apache/shardingsphere/pull/11189#discussion_r665101407
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/dml/select.xml
##########
@@ -81,4 +81,6 @@
<sql-case id="select_with_jsonb_path_predicate_check" value="SELECT content_json::jsonb@@'$.keyword[*]=="ss"' FROM tb_content_json" db-types="PostgreSQL" />
<sql-case id="select_with_assignment_operator" value="SELECT @rn := 1, @now_code := '' FROM t_order" db-types="MySQL" />
<sql-case id="select_from_dual" value="SELECT 1 FROM DUAL" db-types="MySQL" />
+ <sql-case id="select_with_cast_as_signed" value="select user_id,cast(order_id as signed) from t_order" db-types="MySQL"/>
Review comment:
@tuichenchuxin Please keep keywords upper case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org