You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/18 01:54:51 UTC

[GitHub] [superset] codecov[bot] commented on pull request #13682: feat: add Databricks DB engine spec

codecov[bot] commented on pull request #13682:
URL: https://github.com/apache/superset/pull/13682#issuecomment-801556714


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=h1) Report
   > Merging [#13682](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=desc) (957a82a) into [master](https://codecov.io/gh/apache/superset/commit/21cc49509faafa39484ff2978f36557b9d96fc5c?el=desc) (21cc495) will **increase** coverage by `3.28%`.
   > The diff coverage is `89.09%`.
   
   > :exclamation: Current head 957a82a differs from pull request most recent head 77c0555. Consider uploading reports for the commit 77c0555 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13682/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13682      +/-   ##
   ==========================================
   + Coverage   77.41%   80.70%   +3.28%     
   ==========================================
     Files         918      311     -607     
     Lines       46673    25059   -21614     
     Branches     5720        0    -5720     
   ==========================================
   - Hits        36131    20223   -15908     
   + Misses      10406     4836    -5570     
   + Partials      136        0     -136     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.56% <89.09%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.61% <89.09%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.70% <89.09%> (-0.41%)` | :arrow_down: |
   | sqlite | `80.23% <89.09%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <ø> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <0.00%> (-0.04%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `71.42% <50.00%> (+0.51%)` | :arrow_up: |
   | [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <75.00%> (-2.53%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.50% <89.06%> (-0.13%)` | :arrow_down: |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <100.00%> (ø)` | |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.47% <100.00%> (-0.07%)` | :arrow_down: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.81% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (+<0.01%)` | :arrow_up: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.71% <100.00%> (-0.46%)` | :arrow_down: |
   | ... and [600 more](https://codecov.io/gh/apache/superset/pull/13682/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=footer). Last update [21cc495...77c0555](https://codecov.io/gh/apache/superset/pull/13682?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org