You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2016/10/22 19:09:57 UTC
[cdi] regression for case without jaxrs resources?
Hi guys,
think now we have a default Application but without checking we have
anything to deploy. Means that the extension will fail CDI deployment if
the module doesn't need JAX-RS which concretely makes the extension
unusable outside a end user application.
Can it be fixed and deployment skipped if nothing should be deployed?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
Re: [cdi] regression for case without jaxrs resources?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Found another issue: most of the time beanclass is used as representing the
class of the Bean which is not true.
Typically @Produces the bus you need to use
bean.getTypes().contains(Bus.class) to do the check. BeanClass would be
there the producer (enclosing) class.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2016-10-23 16:34 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> 2016-10-23 16:31 GMT+02:00 John D. Ament <jo...@apache.org>:
>
>> On Sat, Oct 22, 2016 at 3:42 PM Romain Manni-Bucau <rmannibucau@gmail.com
>> >
>> wrote:
>>
>> > 2016-10-22 21:31 GMT+02:00 John D. Ament <jo...@apache.org>:
>> >
>> > > On Sat, Oct 22, 2016 at 3:10 PM Romain Manni-Bucau <
>> > rmannibucau@gmail.com>
>> > > wrote:
>> > >
>> > > > Hi guys,
>> > > >
>> > > > think now we have a default Application but without checking we have
>> > > > anything to deploy. Means that the extension will fail CDI
>> deployment
>> > if
>> > > > the module doesn't need JAX-RS which concretely makes the extension
>> > > > unusable outside a end user application.
>> > > >
>> > > > Can it be fixed and deployment skipped if nothing should be
>> deployed?
>> > > >
>> > >
>> > > Yep, I'll raise a PR shortly (eg next day or so). I still want to add
>> > some
>> > > systests for this case. Do you have a JIRA for this or no?
>> > >
>> > >
>> > No, wanted to check it was unintended before.
>> >
>>
>> Well, to put it a different way. The idea that you would include CXF but
>> not deploy any JAX-RS resources hadn't come into my mind when working on
>> it. If its a real use case, can definitely patch it.
>>
>>
> Anywhere where JAXRS is considered as part of the framework/runtime and
> not the application it is so yes I'd do it. In particular cause it is not
> hard to see we only have the default application bean and no resources in
> the extension ;). Can help on that if needed or you have some time issues.
>
>
>>
>>
>> >
>> >
>> > >
>> > > >
>> > > > Romain Manni-Bucau
>> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
>> > > > <http://rmannibucau.wordpress.com> | Github <
>> > > > https://github.com/rmannibucau> |
>> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
>> > > > <http://www.tomitribe.com> | JavaEE Factory
>> > > > <https://javaeefactory-rmannibucau.rhcloud.com>
>> > > >
>> > >
>> >
>>
>
>
Re: [cdi] regression for case without jaxrs resources?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2016-10-23 16:31 GMT+02:00 John D. Ament <jo...@apache.org>:
> On Sat, Oct 22, 2016 at 3:42 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > 2016-10-22 21:31 GMT+02:00 John D. Ament <jo...@apache.org>:
> >
> > > On Sat, Oct 22, 2016 at 3:10 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > Hi guys,
> > > >
> > > > think now we have a default Application but without checking we have
> > > > anything to deploy. Means that the extension will fail CDI deployment
> > if
> > > > the module doesn't need JAX-RS which concretely makes the extension
> > > > unusable outside a end user application.
> > > >
> > > > Can it be fixed and deployment skipped if nothing should be deployed?
> > > >
> > >
> > > Yep, I'll raise a PR shortly (eg next day or so). I still want to add
> > some
> > > systests for this case. Do you have a JIRA for this or no?
> > >
> > >
> > No, wanted to check it was unintended before.
> >
>
> Well, to put it a different way. The idea that you would include CXF but
> not deploy any JAX-RS resources hadn't come into my mind when working on
> it. If its a real use case, can definitely patch it.
>
>
Anywhere where JAXRS is considered as part of the framework/runtime and not
the application it is so yes I'd do it. In particular cause it is not hard
to see we only have the default application bean and no resources in the
extension ;). Can help on that if needed or you have some time issues.
>
>
> >
> >
> > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com> | JavaEE Factory
> > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > >
> > >
> >
>
Re: [cdi] regression for case without jaxrs resources?
Posted by "John D. Ament" <jo...@apache.org>.
On Sat, Oct 22, 2016 at 3:42 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> 2016-10-22 21:31 GMT+02:00 John D. Ament <jo...@apache.org>:
>
> > On Sat, Oct 22, 2016 at 3:10 PM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> > > Hi guys,
> > >
> > > think now we have a default Application but without checking we have
> > > anything to deploy. Means that the extension will fail CDI deployment
> if
> > > the module doesn't need JAX-RS which concretely makes the extension
> > > unusable outside a end user application.
> > >
> > > Can it be fixed and deployment skipped if nothing should be deployed?
> > >
> >
> > Yep, I'll raise a PR shortly (eg next day or so). I still want to add
> some
> > systests for this case. Do you have a JIRA for this or no?
> >
> >
> No, wanted to check it was unintended before.
>
Well, to put it a different way. The idea that you would include CXF but
not deploy any JAX-RS resources hadn't come into my mind when working on
it. If its a real use case, can definitely patch it.
>
>
> >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com> | JavaEE Factory
> > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > >
> >
>
Re: [cdi] regression for case without jaxrs resources?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2016-10-22 21:31 GMT+02:00 John D. Ament <jo...@apache.org>:
> On Sat, Oct 22, 2016 at 3:10 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Hi guys,
> >
> > think now we have a default Application but without checking we have
> > anything to deploy. Means that the extension will fail CDI deployment if
> > the module doesn't need JAX-RS which concretely makes the extension
> > unusable outside a end user application.
> >
> > Can it be fixed and deployment skipped if nothing should be deployed?
> >
>
> Yep, I'll raise a PR shortly (eg next day or so). I still want to add some
> systests for this case. Do you have a JIRA for this or no?
>
>
No, wanted to check it was unintended before.
>
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
>
Re: [cdi] regression for case without jaxrs resources?
Posted by "John D. Ament" <jo...@apache.org>.
On Sat, Oct 22, 2016 at 3:10 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hi guys,
>
> think now we have a default Application but without checking we have
> anything to deploy. Means that the extension will fail CDI deployment if
> the module doesn't need JAX-RS which concretely makes the extension
> unusable outside a end user application.
>
> Can it be fixed and deployment skipped if nothing should be deployed?
>
Yep, I'll raise a PR shortly (eg next day or so). I still want to add some
systests for this case. Do you have a JIRA for this or no?
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>