You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "LucasG0 (via GitHub)" <gi...@apache.org> on 2023/12/15 14:07:34 UTC
[PR] GH-38768: [Python] Slicing an array backwards beyond the start now includes first item. [arrow]
LucasG0 opened a new pull request, #39240:
URL: https://github.com/apache/arrow/pull/39240
### What changes are included in this PR?
Minor changes in `_normalize_slice` so `start` and `stop` are both computed in a single if/else block instead of having them modified later in case of a negative `step`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Fixing wrong data returned in an edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38768: [Python] Slicing an array backwards beyond the start now includes first item. [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39240:
URL: https://github.com/apache/arrow/pull/39240#issuecomment-1930394248
@jorisvandenbossche Would you be available to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38768: [Python] Slicing an array backwards beyond the start now includes first item. [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39240:
URL: https://github.com/apache/arrow/pull/39240#issuecomment-2002283078
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 00a48217e93bea1e84f10dbfdf3c0c93dfe1ea3d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/22747134657) has more details. It also includes information about 107 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38768: [Python] Slicing an array backwards beyond the start now includes first item. [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #39240:
URL: https://github.com/apache/arrow/pull/39240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org