You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/04 20:20:34 UTC

[GitHub] [netbeans] tbw777 opened a new pull request, #5203: Added all missing @Override annotations

tbw777 opened a new pull request, #5203:
URL: https://github.com/apache/netbeans/pull/5203

   @Override annotations are used to detect changing of interfaces at compile time. For example. If parent method signature is changes then javac will stop compiling because of difference with method signature that marked by annotation and so on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1371647991

   Other way is to split this commit by dirs. That do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1407459575

   @vieiro 
   What do i need to do to accomplish all changes here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1407476840

   ty


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1371666700

   Conflicts is normal in git, not understand that is the problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1371643838

   I think that conflicts of other changes can be done by authors. The current commit has no any conflicts with master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 closed pull request #5203: Added all missing @Override annotations

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5203: Added all missing @Override annotations
URL: https://github.com/apache/netbeans/pull/5203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #5203: Added all missing @Override annotations

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1407462969

   we are going to merge 5189 first after 17rc3 is released.
   see discussion on the dev list:
   https://lists.apache.org/thread/f7mt7k3rb11sgjj1fo2vlflczvw3oycx
   
   After that we take a look how to best integrate the other PRs. We might wait with this PR until NB 17 is released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1372203077

   https://github.com/apache/netbeans/pull/5189 restored, it fully back compatible with this changes. But i think that the best way to merge this main 5203 PR commit single time and forget about


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1371647307

   > I think that conflicts of other changes can be done by authors. The current commit has no any conflicts with master
   
   thats the point. We should avoid that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1371630239

   this might cause a lot of merge conflicts. I am not sure if this is a good idea to integrate this as is - its also difficult to review.
   
   I would have preferred the already reviewed platform PR which was in an area of less pending PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 commented on pull request #5203: Added all missing @Override annotations

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5203:
URL: https://github.com/apache/netbeans/pull/5203#issuecomment-1372599657

   I think this commit willnt produce any conflicts because no one method changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tbw777 closed pull request #5203: Added all missing @Override annotations

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5203: Added all missing @Override annotations
URL: https://github.com/apache/netbeans/pull/5203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists