You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lucasbru (via GitHub)" <gi...@apache.org> on 2025/06/19 12:27:26 UTC
[PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
lucasbru opened a new pull request, #19999:
URL: https://github.com/apache/kafka/pull/19999
`streams_broker_down_resilience_test` produce messages with `null` key to a topic with three partitions and expect each partition to be non-empty afterward. But I don't think this is a correct assumption, as a producer may try to be sticky and only produce to two partitions.
This cause occasional flakiness in the test.
The fix is to produce records with keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #19999:
URL: https://github.com/apache/kafka/pull/19999#discussion_r2156902776
##########
tests/kafkatest/tests/streams/streams_broker_down_resilience_test.py:
##########
@@ -129,10 +129,12 @@ def test_streams_runs_with_broker_down_initially(self, metadata_quorum, group_pr
with processor_2.node.account.monitor_log(processor_2.STDOUT_FILE) as monitor_2:
with processor_3.node.account.monitor_log(processor_3.STDOUT_FILE) as monitor_3:
+ # repeating_keys enables production of records with keys, ensuring that we produce to all 3 partitions
self.assert_produce(self.inputTopic,
"sending_message_after_broker_down_initially",
num_messages=self.num_messages,
- timeout_sec=120)
+ timeout_sec=120,
+ repeating_keys=self.num_messages)
Review Comment:
[nitpick] This comment is repeated verbatim across multiple test cases. Consider abstracting the key-production logic into a helper or adding a shared comment to reduce duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #19999:
URL: https://github.com/apache/kafka/pull/19999#issuecomment-2990336231
Thanks for the comment @FrankYang0529
> Out of curiosity, do we want to introduce repeating_keys to assert_produce_consume as well?
We could, but it's not necessary, because in that case we only assert that our messages are produced to / consumed from any partition. For `assert_produce` we add it, to support the assertion that all partitions have data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #19999:
URL: https://github.com/apache/kafka/pull/19999#issuecomment-2990412834
Here are 40 passing runs (across all parameters) of the test with this PR. Not sure if this is sufficient to trigger the original flake, but at least it should show that I didn't break things:
https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-06-19--001.f4645ca5-144e-40cd-85c5-16efd1b32e71--1750341166--lucasbru--deflake_streams_broker_down_resilience_test--c06d4dedde/report.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru merged PR #19999:
URL: https://github.com/apache/kafka/pull/19999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19421: Deflake streams_broker_down_resilience_test [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #19999:
URL: https://github.com/apache/kafka/pull/19999#issuecomment-2990554239
PTAL @aliehsaeedii
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org