You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Akshay Goyal <ak...@gmail.com> on 2015/09/13 15:14:22 UTC

Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 13, 2015, 1:14 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

changes for retrieving queue number from waiting queries collection.


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [24.281s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
[INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
[INFO] Lens DB storage ................................... SUCCESS [19.132s]
[INFO] Lens Query Library ................................ SUCCESS [14.881s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
[INFO] Lens Server ....................................... SUCCESS [5:35.820s]
[INFO] Lens client ....................................... SUCCESS [36.048s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
[INFO] Lens Examples ..................................... SUCCESS [8.941s]
[INFO] Lens Distribution ................................. SUCCESS [8.296s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
[INFO] Lens Regression ................................... SUCCESS [11.972s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:06.610s
[INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
[INFO] Final Memory: 193M/1887M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98828
-----------------------------------------------------------

Ship it!



lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java (line 94)
<https://reviews.apache.org/r/37716/#comment155434>

    Should the name of variable here be 'queuedQuery' ?


- Amareshwari Sriramadasu


On Sept. 14, 2015, 9:02 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 9:02 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98837
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 14, 2015, 12:07 p.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 12:07 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.050s]
> [INFO] Lens .............................................. SUCCESS [3.139s]
> [INFO] Lens API .......................................... SUCCESS [24.528s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.310s]
> [INFO] Lens Cube ......................................... SUCCESS [5:12.292s]
> [INFO] Lens DB storage ................................... SUCCESS [19.318s]
> [INFO] Lens Query Library ................................ SUCCESS [16.207s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.394s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.664s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.377s]
> [INFO] Lens Server ....................................... SUCCESS [5:44.102s]
> [INFO] Lens client ....................................... SUCCESS [38.027s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.369s]
> [INFO] Lens Examples ..................................... SUCCESS [8.288s]
> [INFO] Lens Distribution ................................. SUCCESS [8.495s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.983s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.216s]
> [INFO] Lens Regression ................................... SUCCESS [10.034s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:07.695s
> [INFO] Finished at: Mon Sep 14 12:04:07 UTC 2015
> [INFO] Final Memory: 193M/1889M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 12:07 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.050s]
[INFO] Lens .............................................. SUCCESS [3.139s]
[INFO] Lens API .......................................... SUCCESS [24.528s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.310s]
[INFO] Lens Cube ......................................... SUCCESS [5:12.292s]
[INFO] Lens DB storage ................................... SUCCESS [19.318s]
[INFO] Lens Query Library ................................ SUCCESS [16.207s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.394s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.664s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.377s]
[INFO] Lens Server ....................................... SUCCESS [5:44.102s]
[INFO] Lens client ....................................... SUCCESS [38.027s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.369s]
[INFO] Lens Examples ..................................... SUCCESS [8.288s]
[INFO] Lens Distribution ................................. SUCCESS [8.495s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.983s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.216s]
[INFO] Lens Regression ................................... SUCCESS [10.034s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:07.695s
[INFO] Finished at: Mon Sep 14 12:04:07 UTC 2015
[INFO] Final Memory: 193M/1889M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 9:19 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

using correct variable name.


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [24.281s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
[INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
[INFO] Lens DB storage ................................... SUCCESS [19.132s]
[INFO] Lens Query Library ................................ SUCCESS [14.881s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
[INFO] Lens Server ....................................... SUCCESS [5:35.820s]
[INFO] Lens client ....................................... SUCCESS [36.048s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
[INFO] Lens Examples ..................................... SUCCESS [8.941s]
[INFO] Lens Distribution ................................. SUCCESS [8.296s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
[INFO] Lens Regression ................................... SUCCESS [11.972s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:06.610s
[INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
[INFO] Final Memory: 193M/1887M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 9:02 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [24.281s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
[INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
[INFO] Lens DB storage ................................... SUCCESS [19.132s]
[INFO] Lens Query Library ................................ SUCCESS [14.881s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
[INFO] Lens Server ....................................... SUCCESS [5:35.820s]
[INFO] Lens client ....................................... SUCCESS [36.048s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
[INFO] Lens Examples ..................................... SUCCESS [8.941s]
[INFO] Lens Distribution ................................. SUCCESS [8.296s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
[INFO] Lens Regression ................................... SUCCESS [11.972s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:06.610s
[INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
[INFO] Final Memory: 193M/1887M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98819
-----------------------------------------------------------



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 618)
<https://reviews.apache.org/r/37716/#comment155424>

    Set queue number as null for launched queries?


- Amareshwari Sriramadasu


On Sept. 14, 2015, 7:42 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 7:42 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.

> On Sept. 14, 2015, 8:24 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, lines 164-179
> > <https://reviews.apache.org/r/37716/diff/5/?file=1072235#file1072235line164>
> >
> >     Can we reuse status.toString here? Both have similar code snippets. Maybe the toString will need some modifications to be generic enough to be usable here.

Done.


- Akshay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98823
-----------------------------------------------------------


On Sept. 14, 2015, 9:02 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 9:02 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98823
-----------------------------------------------------------



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (lines 164 - 179)
<https://reviews.apache.org/r/37716/#comment155431>

    Can we reuse status.toString here? Both have similar code snippets. Maybe the toString will need some modifications to be generic enough to be usable here.


- Rajat Khandelwal


On Sept. 14, 2015, 1:12 p.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:12 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 7:42 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Review comments addressed.


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [24.281s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
[INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
[INFO] Lens DB storage ................................... SUCCESS [19.132s]
[INFO] Lens Query Library ................................ SUCCESS [14.881s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
[INFO] Lens Server ....................................... SUCCESS [5:35.820s]
[INFO] Lens client ....................................... SUCCESS [36.048s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
[INFO] Lens Examples ..................................... SUCCESS [8.941s]
[INFO] Lens Distribution ................................. SUCCESS [8.296s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
[INFO] Lens Regression ................................... SUCCESS [11.972s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:06.610s
[INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
[INFO] Final Memory: 193M/1887M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.

> On Sept. 14, 2015, 6:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 811
> > <https://reviews.apache.org/r/37716/diff/4/?file=1072081#file1072081line811>
> >
> >     Should we set only if index returned is a valid index?
> >     
> >     Index may not be returned when it is in priority queue. And returning previos queue position would make sense in those cases.

Makes sense. Updated.


- Akshay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98814
-----------------------------------------------------------


On Sept. 14, 2015, 7:42 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 7:42 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/#review98814
-----------------------------------------------------------



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (line 174)
<https://reviews.apache.org/r/37716/#comment155412>

    Have text as "Position in queue"



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (line 174)
<https://reviews.apache.org/r/37716/#comment155413>

    Have text as "Position in queue" here as well.



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 811)
<https://reviews.apache.org/r/37716/#comment155416>

    Should we set only if index returned is a valid index?
    
    Index may not be returned when it is in priority queue. And returning previos queue position would make sense in those cases.



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1013)
<https://reviews.apache.org/r/37716/#comment155417>

    We need to check if any of the semantics change now, wrt this change.


- Amareshwari Sriramadasu


On Sept. 14, 2015, 4:57 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37716/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 4:57 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-753
>     https://issues.apache.org/jira/browse/LENS-753
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Queue number for queries in submitted queue
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 
> 
> Diff: https://reviews.apache.org/r/37716/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [24.281s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
> [INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
> [INFO] Lens DB storage ................................... SUCCESS [19.132s]
> [INFO] Lens Query Library ................................ SUCCESS [14.881s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.820s]
> [INFO] Lens client ....................................... SUCCESS [36.048s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
> [INFO] Lens Examples ..................................... SUCCESS [8.941s]
> [INFO] Lens Distribution ................................. SUCCESS [8.296s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
> [INFO] Lens Regression ................................... SUCCESS [11.972s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:06.610s
> [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
> [INFO] Final Memory: 193M/1887M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37716: LENS-753: Queue number for queries in submitted queue

Posted by Akshay Goyal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37716/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 4:57 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

fixed enunciate error


Bugs: LENS-753
    https://issues.apache.org/jira/browse/LENS-753


Repository: lens


Description
-------

Queue number for queries in submitted queue


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 44c0c62 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java f78b7c3 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72f 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java 344ff10 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 23cc748 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java e3505bb 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java f9e7701 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java cdbd2ad 
  lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java 7b43a38 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java 7a81e83 
  lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java 51fcf00 

Diff: https://reviews.apache.org/r/37716/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [24.281s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.248s]
[INFO] Lens Cube ......................................... SUCCESS [5:16.136s]
[INFO] Lens DB storage ................................... SUCCESS [19.132s]
[INFO] Lens Query Library ................................ SUCCESS [14.881s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s]
[INFO] Lens Server ....................................... SUCCESS [5:35.820s]
[INFO] Lens client ....................................... SUCCESS [36.048s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.600s]
[INFO] Lens Examples ..................................... SUCCESS [8.941s]
[INFO] Lens Distribution ................................. SUCCESS [8.296s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s]
[INFO] Lens Regression ................................... SUCCESS [11.972s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:06.610s
[INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015
[INFO] Final Memory: 193M/1887M
[INFO] ------------------------------------------------------------------------


Thanks,

Akshay Goyal