You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/12 12:06:33 UTC
[GitHub] [doris] starocean999 opened a new pull request, #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
starocean999 opened a new pull request, #13332:
URL: https://github.com/apache/doris/pull/13332
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13332:
URL: https://github.com/apache/doris/pull/13332#issuecomment-1277006308
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13332:
URL: https://github.com/apache/doris/pull/13332#issuecomment-1277006275
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13332:
URL: https://github.com/apache/doris/pull/13332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gavinchou commented on a diff in pull request #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
Posted by GitBox <gi...@apache.org>.
gavinchou commented on code in PR #13332:
URL: https://github.com/apache/doris/pull/13332#discussion_r1002513501
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -164,9 +164,18 @@ template <typename T>
void ColumnDecimal<T>::update_hashes_with_value(uint64_t* __restrict hashes,
const uint8_t* __restrict null_data) const {
auto s = size();
- for (int i = 0; i < s; i++) {
- hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), sizeof(T),
- hashes[i]);
+ if (null_data) {
Review Comment:
Would it be better to express the logic as the following to save LOC?
```
for (int i = 0; i < s; i++) {
if (null_data != nullptr && null_data[i] != 0) continue;
hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), sizeof(T),
hashes[i]);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13332: [fix](hash)update_hashes_with_value method should handle if input value is null
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13332:
URL: https://github.com/apache/doris/pull/13332#discussion_r993556849
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -164,9 +164,21 @@ template <typename T>
void ColumnDecimal<T>::update_hashes_with_value(uint64_t* __restrict hashes,
const uint8_t* __restrict null_data) const {
auto s = size();
- for (int i = 0; i < s; i++) {
- hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), sizeof(T),
- hashes[i]);
+ if (null_data) {
+ for (int i = 0; i < s; i++) {
+ if (null_data[i] == 0) {
+ hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]),
+ sizeof(T), hashes[i]);
+ }
+ else {
Review Comment:
here seems do not need compute again ？ just do nothing is ok ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org