You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/03/05 14:53:07 UTC
[GitHub] [parquet-mr] andersonm-ibm opened a new pull request #877: PARQUET-1992: Move submodules update to ci-test profile and encryption interop test to maven integration-test phase
andersonm-ibm opened a new pull request #877:
URL: https://github.com/apache/parquet-mr/pull/877
This PR is one of the options to solve the problem "Cannot build from tarball because of git submodules".
1. encryption interop tests run separately from unit tests - in integration-test phase
2. Files for interop tests are downloaded using git submodules in ci-test maven profile only
- `mvn package/install` - doesn't run interop tests
- `mvn verify` - runs interop tests, fails if submodule files are not there
- `mvn verify -P ci-test` - update git submodules and then run interop test, fail if not inside git repo, e.g. if it's a tarball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #877: PARQUET-1992: Move submodules update to ci-test profile and encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #877:
URL: https://github.com/apache/parquet-mr/pull/877#issuecomment-796827049
Closing this one in favor of #878.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky closed pull request #877: PARQUET-1992: Move submodules update to ci-test profile and encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky closed pull request #877:
URL: https://github.com/apache/parquet-mr/pull/877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #877: PARQUET-1992: Move submodules update to ci-test profile and encryption interop test to maven integration-test phase
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #877:
URL: https://github.com/apache/parquet-mr/pull/877#issuecomment-792959931
Thanks a lot for taking the time to implement two separate solutions. I've reviewed the other PR already. Let me postpone/cancel the reviewing of this one until we all agree the other one is the preferred one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org