You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/02/01 16:35:45 UTC
[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1569
[FLINK-3265][tests] adapt RabbitMQ checkpointing test to runtime behavior
This reverts the previous fix as this was merely a bug in the test. The methods `snapshotState` and `notifyCheckpointComplete` are always called mutually exclusive.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1569
----
commit 04d02c732e1113d6817f69474e7cee8849906d27
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-02-01T15:28:07Z
Revert "[FLINK-3265] [rabbitmq] Fix concurrency bug in RabbitMQ"
This reverts commit 6b01a89020f2de3f7710cf72336291b1e8ca8562.
commit ffe24944f4ad3f7f979caa2b085617843a4c7a87
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-02-01T15:30:52Z
[FLINK-3265][tests] adapt checkpointing test to runtime behavior
- snapshotState and notifyCheckpointComplete are always mutually exclusive
This closes #1560.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1569#discussion_r51432976
--- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java ---
@@ -219,7 +140,9 @@ public void testCheckpointing() throws Exception {
}
// check if the messages are being acknowledged and the transaction comitted
- source.notifyCheckpointComplete(snapshotId);
+ synchronized (DummySourceContext.lock) {
--- End diff --
Yes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1569#discussion_r51432473
--- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java ---
@@ -219,7 +140,9 @@ public void testCheckpointing() throws Exception {
}
// check if the messages are being acknowledged and the transaction comitted
- source.notifyCheckpointComplete(snapshotId);
+ synchronized (DummySourceContext.lock) {
--- End diff --
So this is the fix of the actual issue, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---