You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2023/11/09 08:58:23 UTC

[PR] [brach-2.0](pick#25802) Fix decimal precision and scale wrong when create table like (#25802) [doris]

seawinde opened a new pull request, #26666:
URL: https://github.com/apache/doris/pull/26666

   ## Proposed changes
   
   Use field datatype such as decimal(10, 0) to create table like. Because the scale is 0, the precision and scale will lost when create table like done. this will fix the bug.
   
   **Before fix, create table with following SQL**:
   CREATE TABLE IF NOT EXISTS db_test.table_test
   (
       `name` varchar COMMENT "1m size",
       `id` SMALLINT COMMENT "[-32768, 32767]",
       `timestamp0` decimal null comment "c0",
       `timestamp1` decimal(38, 0) null comment "c1"
   )
   DISTRIBUTED BY HASH(`id`) BUCKETS 1
   PROPERTIES ('replication_num' = '1');
   
   **and Then run**
   CREATE TABLE db_test.table_test_like LIKE db_test.table_test SHOW CREATE TABLE db_test.table_test_like;
   
   the field `timestamp1` will be decimal(9, 0), it's wrong. this will fix it.
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [brach-2.0](pick#25802) Fix decimal precision and scale wrong when create table like (#25802) [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #26666:
URL: https://github.com/apache/doris/pull/26666#issuecomment-1803412209

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [brach-2.0](pick#25802) Fix decimal precision and scale wrong when create table like (#25802) [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #26666:
URL: https://github.com/apache/doris/pull/26666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [brach-2.0](pick#25802) Fix decimal precision and scale wrong when create table like (#25802) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26666:
URL: https://github.com/apache/doris/pull/26666#issuecomment-1803482303

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.9 seconds
    stream load tsv:          553 seconds loaded 74807831229 Bytes, about 129 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
    storage size: 17161951737 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org