You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/31 07:54:58 UTC
[jira] [Commented] (CURATOR-372) CompressionProvider Function
Signatures should not include the path
[ https://issues.apache.org/jira/browse/CURATOR-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15789131#comment-15789131 ]
ASF GitHub Bot commented on CURATOR-372:
----------------------------------------
GitHub user mridulv opened a pull request:
https://github.com/apache/curator/pull/180
CURATOR-372 Removed Path from the Compression Provider
This is in accordance to this ISSUE https://issues.apache.org/jira/browse/CURATOR-372
We are unnecessarily passing this information to the compression provider.
CompressionProvider should be agnostic with the path.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mridulv/curator mridul-cleanup-compressionProvider
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
----
commit e90a0123a79dd9ae4b4613203ae207365f0f6a58
Author: MRIDUL VERMA <mr...@sumologic.com>
Date: 2016-12-31T07:47:32Z
CURATOR-372 Removed Path from the Compression Provider and from all its Usages
----
> CompressionProvider Function Signatures should not include the path
> -------------------------------------------------------------------
>
> Key: CURATOR-372
> URL: https://issues.apache.org/jira/browse/CURATOR-372
> Project: Apache Curator
> Issue Type: Task
> Components: Framework
> Reporter: Mridul Verma
> Priority: Trivial
>
> Currently in Curator-Framework in Compression Provider, we
> {code}
> compress(String path, byte[] data)
> {code}
> we use the path, but the `path` is not required for this functionality.
> So we should clean this up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)