You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by "Python_Max (JIRA)" <ji...@apache.org> on 2016/12/05 15:38:58 UTC

[jira] [Created] (ZEPPELIN-1754) PING request stacking on websocket reconnect

Python_Max created ZEPPELIN-1754:
------------------------------------

             Summary: PING request stacking on websocket reconnect
                 Key: ZEPPELIN-1754
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1754
             Project: Zeppelin
          Issue Type: Bug
          Components: front-end
    Affects Versions: 0.6.2
            Reporter: Python_Max


PING request should be executed every 10 seconds.
But when server gets restarted there will be one more setInterval() closure stacking each time (see websocketEvents.factory.js -> websocketCalls.ws.onOpen).

Steps to reproduce:
1) build Zeppelin leaving console.log enabled
2) start ZeppelinServer, open any notebook in browser
3) open console with timestamps and check that PING request repeats exactly once in every 10 second
4) restart ZeppelinServer but do not close or refresh the notebook page
5) wait for websocket connection reopened
6) check PING request frequency in console

It will be 2 PING requests in every 10 seconds. Expected only one. Repeating steps 4-6 will add one more request per 10 seconds.

I think clearInterval() should be called in websocket's onClose() handler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)