You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/20 06:16:28 UTC

[kudu-CR] [macos] fix build on macOS (Xcode 12.4 and earlier)

Hello Marton Greber, Zoltan Chovan, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18820

to look at the new patch set (#3).

Change subject: [macos] fix build on macOS (Xcode 12.4 and earlier)
......................................................................

[macos] fix build on macOS (Xcode 12.4 and earlier)

The change introduced by [1] broke build on my macOS laptop
with Xcode 12.4.

This patch addresses the issue: as it turned out, starting with
Xcode 12.5 the location of the libc++ headers changed, so it's necessary
to use different approaches for different Xcode versions (for details,
see the comment added in src/kudu/codegen/CMakeLists.txt).

I verified the new approach works on my Intel-based laptop:
  * macOS Catalina 10.15.7 with Xcode 11.7, 12.4
  * macOS BigSur 11.6.8 with Xcode 11.7, 12.4, 12.5, 13.2.1.

[1] https://github.com/apache/kudu/commit/543e128d473f8f7836e605bba8cd6512fa918550

Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 41 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18820/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0
Gerrit-Change-Number: 18820
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>