You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/14 09:53:50 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #1916: Spark JVM support

ppalaga opened a new pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916


   Related https://github.com/apache/camel-quarkus/issues/1701


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-709922992


   I should document the peculiarities.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-709922704


   > I wonder if we should place the spark specific version properties within the spark bom and keep them out of the root pom. WDYT?
   
   I'd like to have them in the top pom so that everyone can see that those artifacts are used somewhere. I find this important for the case that they pop up through some other extension. In such a case we should make a conscious decision whether they should be managed in the main BOM or somewhere else. That could get forgotten easily if there is no trace of them in the top pom. WDYT?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-709561654


   a1b5695 :
   * Added a proper test
   * dependencyManagement in a separate camel-quarkus-spark-bom
   
   Please re-review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga edited a comment on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-709922992


   I should document the peculiarities https://github.com/apache/camel-quarkus/issues/1928


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-708305794


   Let me write a test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1916: Spark JVM support

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1916:
URL: https://github.com/apache/camel-quarkus/pull/1916#issuecomment-709930541


   > That could get forgotten easily if there is no trace of them in the top pom. WDYT?
   
   Ok - fine with me to keep them in the root pom.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org