You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/06/19 08:45:30 UTC

svn commit: r1890906 - /pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java

Author: tilman
Date: Sat Jun 19 08:45:30 2021
New Revision: 1890906

URL: http://svn.apache.org/viewvc?rev=1890906&view=rev
Log:
PDFBOX-4892: optimize / simplify, as suggested by valerybokov

Modified:
    pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java

Modified: pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java?rev=1890906&r1=1890905&r2=1890906&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java (original)
+++ pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java Sat Jun 19 08:45:30 2021
@@ -81,11 +81,6 @@ public abstract class AbstractField
      */
     public final void setAttribute(Attribute value)
     {
-        if (attributes.containsKey(value.getName()))
-        {
-            // if same name in element, attribute will be replaced
-            attributes.remove(value.getName());
-        }
         attributes.put(value.getName(), value);
     }
 
@@ -131,10 +126,7 @@ public abstract class AbstractField
      */
     public final void removeAttribute(String qualifiedName)
     {
-        if (containsAttribute(qualifiedName))
-        {
-            attributes.remove(qualifiedName);
-        }
+        attributes.remove(qualifiedName);
 
     }