You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:00:44 UTC
[GitHub] [incubator-tvm] roastduck opened a new issue #6490: [RELAY] Inaccurate doc for nn.dense
roastduck opened a new issue #6490:
URL: https://github.com/apache/incubator-tvm/issues/6490
https://github.com/apache/incubator-tvm/blob/b8d385c2ab741cb254aa700b48546799273276ee/python/tvm/relay/op/nn/nn.py#L1388
Doc of `nn.dense` says it compute `Y = X * W`, but it should actually be `Y = X * W^T` as the shape checking below.
https://github.com/apache/incubator-tvm/blob/b8d385c2ab741cb254aa700b48546799273276ee/src/relay/op/nn/nn.h#L66
I think we'd better doc this transposition (or memory layout).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] roastduck closed issue #6490: [RELAY] Inaccurate doc for nn.dense
Posted by GitBox <gi...@apache.org>.
roastduck closed issue #6490:
URL: https://github.com/apache/incubator-tvm/issues/6490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] roastduck commented on issue #6490: [RELAY] Inaccurate doc for nn.dense
Posted by GitBox <gi...@apache.org>.
roastduck commented on issue #6490:
URL: https://github.com/apache/incubator-tvm/issues/6490#issuecomment-694677515
Fixed in #6508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #6490: [RELAY] Inaccurate doc for nn.dense
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6490:
URL: https://github.com/apache/incubator-tvm/issues/6490#issuecomment-693506355
Rgabjs @roastduck , a PR is more than welcomed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org