You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "sandeep318kumar (via GitHub)" <gi...@apache.org> on 2024/09/09 21:53:27 UTC
[PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
sandeep318kumar opened a new pull request, #3825:
URL: https://github.com/apache/ambari/pull/3825
## What changes were proposed in this pull request?
[AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0
(Please fill in changes proposed in this fix)
## How was this patch tested?
Installed a local with the changes and tested all functionalities. All metrics are coming in ambari UI. Check https://issues.apache.org/jira/browse/AMBARI-26076 for references
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on code in PR #3825:
URL: https://github.com/apache/ambari/pull/3825#discussion_r1764277332
##########
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java:
##########
Review Comment:
The reason for deleting TimelineMetricCacheSizingTest?
##########
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java:
##########
@@ -319,4 +322,24 @@ private long getMillisecondsTime(long time) {
return time;
}
}
+ @Override
+ public void delete(TimelineAppMetricCacheKey key) throws CacheWritingException {
+ // no need to implement.
+ }
+
+ @Override
+ public Map<TimelineAppMetricCacheKey, TimelineMetricsCacheValue> loadAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheLoadingException, Exception {
+// no need to implement.
+ return null;
+ }
+
+ @Override
+ public void writeAll(Iterable<? extends Map.Entry<? extends TimelineAppMetricCacheKey, ? extends TimelineMetricsCacheValue>> entries) throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
+
+ @Override
+ public void deleteAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
Review Comment:
If the code here is not specifically implemented, can it be removed？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3825:
URL: https://github.com/apache/ambari/pull/3825#issuecomment-2362500334
@virajjasani Could also check this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on PR #3825:
URL: https://github.com/apache/ambari/pull/3825#issuecomment-2355342033
> @sandeep318kumar Thank you very much for your contribution. Please check the CI/CD for this PR.
CI has passed for this @JiaLiangC, Can you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on code in PR #3825:
URL: https://github.com/apache/ambari/pull/3825#discussion_r1766266498
##########
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java:
##########
@@ -319,4 +322,24 @@ private long getMillisecondsTime(long time) {
return time;
}
}
+ @Override
+ public void delete(TimelineAppMetricCacheKey key) throws CacheWritingException {
+ // no need to implement.
+ }
+
+ @Override
+ public Map<TimelineAppMetricCacheKey, TimelineMetricsCacheValue> loadAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheLoadingException, Exception {
+// no need to implement.
+ return null;
+ }
+
+ @Override
+ public void writeAll(Iterable<? extends Map.Entry<? extends TimelineAppMetricCacheKey, ? extends TimelineMetricsCacheValue>> entries) throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
+
+ @Override
+ public void deleteAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
Review Comment:
@JiaLiangC
We are implementing CacheLoaderWriter interface, that's why we need to provide implementation of all its methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on code in PR #3825:
URL: https://github.com/apache/ambari/pull/3825#discussion_r1766267402
##########
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java:
##########
Review Comment:
Ehcache 3.10.0 doesn't have support of sizeOf, as we have removed it from src code and removed the test file as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on PR #3825:
URL: https://github.com/apache/ambari/pull/3825#issuecomment-2364600286
@arshadmohammad @vishalsuvagia Can you check this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "vishalsuvagia (via GitHub)" <gi...@apache.org>.
vishalsuvagia commented on PR #3825:
URL: https://github.com/apache/ambari/pull/3825#issuecomment-2339647380
@sandeep318kumar build has failed, can you kindly check the failure for missing library, try excluding the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC merged PR #3825:
URL: https://github.com/apache/ambari/pull/3825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] [AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3825:
URL: https://github.com/apache/ambari/pull/3825#issuecomment-2339437058
@sandeep318kumar Thank you very much for your contribution. Please check the CI/CD for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org