You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by gr...@apache.org on 2002/04/01 23:07:14 UTC
cvs commit: apr STATUS
gregames 02/04/01 13:07:13
Modified: build apr_hints.m4
. STATUS
Log:
FreeBSD: use fcntl cross-process locks by default. Make note of problems
experienced with flock and SysV sems.
Revision Changes Path
1.38 +5 -0 apr/build/apr_hints.m4
Index: apr_hints.m4
===================================================================
RCS file: /home/cvs/apr/build/apr_hints.m4,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- apr_hints.m4 28 Mar 2002 15:10:51 -0000 1.37
+++ apr_hints.m4 1 Apr 2002 21:07:13 -0000 1.38
@@ -135,6 +135,11 @@
;;
esac
APR_SETIFNULL(enable_threads, [no])
+
+dnl XXX Fix me - Apache 1.3 used FLOCK serialization by default on FreeBSD,
+dnl but that doesn't work any more.
+
+ APR_SETIFNULL(apr_lock_method, [USE_FCNTL_SERIALIZE])
APR_ADDTO(CPPFLAGS, [-D_REENTRANT -D_THREAD_SAFE])
;;
*-next-nextstep*)
1.107 +6 -1 apr/STATUS
Index: STATUS
===================================================================
RCS file: /home/cvs/apr/STATUS,v
retrieving revision 1.106
retrieving revision 1.107
diff -u -r1.106 -r1.107
--- STATUS 22 Mar 2002 18:08:23 -0000 1.106
+++ STATUS 1 Apr 2002 21:07:13 -0000 1.107
@@ -1,5 +1,5 @@
APACHE PORTABLE RUNTIME (APR) LIBRARY STATUS: -*-text-*-
-Last modified at [$Date: 2002/03/22 18:08:23 $]
+Last modified at [$Date: 2002/04/01 21:07:13 $]
Release:
@@ -313,6 +313,11 @@
file. Note: Win2K fails GetFileAttributesEx in this scenario.
See OtherBill's comments in this message to dev@httpd.apache.org:
Message-Id: <5....@localhost>
+
+ * FreeBSD: flock cross-process locks fail in apr_proc_mutex_child_init
+ with EBADF. flock was the default accept serialization method in
+ Apache 1.3. SysV sems fail with ENOSPC during apr_lock_create on
+ daedalus.
Documentation that needs writing:
Re: cvs commit: apr STATUS
Posted by Greg Ames <gr...@remulak.net>.
gregames@apache.org wrote:
>
> gregames 02/04/01 13:07:13
>
> Modified: build apr_hints.m4
> . STATUS
> Log:
> FreeBSD: use fcntl cross-process locks by default. Make note of problems
> experienced with flock and SysV sems.
I'll update this as appropriate after applying Jeff's patch for flock.
Greg
Re: cvs commit: apr STATUS
Posted by Jeff Trawick <tr...@attglobal.net>.
gregames@apache.org writes:
> gregames 02/04/01 13:07:13
>
> Modified: build apr_hints.m4
> . STATUS
> Log:
> FreeBSD: use fcntl cross-process locks by default. Make note of problems
> experienced with flock and SysV sems.
I just committed a fix for flock-based locks. They now work for me on
FreeBSD 3.4. Try it at your leisure :)
As far as the ENOSPC failure, I would assume that it is not a software
problem until/unless we get better doc. SysV sems work fine for me on
FreeBSD 3.4.
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...
Re: cvs commit: apr STATUS
Posted by Jeff Trawick <tr...@attglobal.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> Are these also for consideration in the 2.0.34 release?
> >gregames 02/04/01 13:07:13
> >
> > Modified: build apr_hints.m4
> > . STATUS
> > Log:
> > FreeBSD: use fcntl cross-process locks by default. Make note of problems
> > experienced with flock and SysV sems.
I think a later level of apr_hints.m4 is desirable... this particular
change to apr_hints.m4 was a temporary work-around.
Revision 1.39, which supercedes 1.38 (mentioned above), needs to
have the tag.
> >trawick 02/04/01 13:03:04
> >
> > Modified: . CHANGES
> > locks/unix proc_mutex.c
> > Log:
> > Get flock-based mutexes to work in apps like Apache. Use the
> > same permissions on flock- and fcntl-based mutexes as Apache
> > 1.3.
This was pure fix and is necessary for the eventual FreeBSD fix
(apr_hints.m4 revision 1.39).
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...
Re: cvs commit: apr STATUS
Posted by Jeff Trawick <tr...@attglobal.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> Are these also for consideration in the 2.0.34 release?
> >gregames 02/04/01 13:07:13
> >
> > Modified: build apr_hints.m4
> > . STATUS
> > Log:
> > FreeBSD: use fcntl cross-process locks by default. Make note of problems
> > experienced with flock and SysV sems.
I think a later level of apr_hints.m4 is desirable... this particular
change to apr_hints.m4 was a temporary work-around.
Revision 1.39, which supercedes 1.38 (mentioned above), needs to
have the tag.
> >trawick 02/04/01 13:03:04
> >
> > Modified: . CHANGES
> > locks/unix proc_mutex.c
> > Log:
> > Get flock-based mutexes to work in apps like Apache. Use the
> > same permissions on flock- and fcntl-based mutexes as Apache
> > 1.3.
This was pure fix and is necessary for the eventual FreeBSD fix
(apr_hints.m4 revision 1.39).
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...
Re: cvs commit: apr STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 05:17 PM 4/2/2002, you wrote:
>Here are the revision numbers:
>
>apr/build/apr_hints.m4, revision 1.39
>apr/locks/unix/proc_mutex.c, revision 1.13
Now adopted by APACHE_2_0_34; thanks!
Re: cvs commit: apr STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Are these also for consideration in the 2.0.34 release?
Bill
>gregames 02/04/01 13:07:13
>
> Modified: build apr_hints.m4
> . STATUS
> Log:
> FreeBSD: use fcntl cross-process locks by default. Make note of problems
> experienced with flock and SysV sems.
>
> Revision Changes Path
> 1.38 +5 -0 apr/build/apr_hints.m4
> 1.107 +6 -1 apr/STATUS
>trawick 02/04/01 13:03:04
>
> Modified: . CHANGES
> locks/unix proc_mutex.c
> Log:
> Get flock-based mutexes to work in apps like Apache. Use the
> same permissions on flock- and fcntl-based mutexes as Apache
> 1.3.
>
> Revision Changes Path
> 1.251 +4 -0 apr/CHANGES
> 1.13 +6 -4 apr/locks/unix/proc_mutex.c
Re: cvs commit: apr STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Are these also for consideration in the 2.0.34 release?
Bill
>gregames 02/04/01 13:07:13
>
> Modified: build apr_hints.m4
> . STATUS
> Log:
> FreeBSD: use fcntl cross-process locks by default. Make note of problems
> experienced with flock and SysV sems.
>
> Revision Changes Path
> 1.38 +5 -0 apr/build/apr_hints.m4
> 1.107 +6 -1 apr/STATUS
>trawick 02/04/01 13:03:04
>
> Modified: . CHANGES
> locks/unix proc_mutex.c
> Log:
> Get flock-based mutexes to work in apps like Apache. Use the
> same permissions on flock- and fcntl-based mutexes as Apache
> 1.3.
>
> Revision Changes Path
> 1.251 +4 -0 apr/CHANGES
> 1.13 +6 -4 apr/locks/unix/proc_mutex.c