You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/02/27 03:41:09 UTC
[Impala-ASF-CR] Make error message for backend test validation more clear
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12620
Change subject: Make error message for backend test validation more clear
......................................................................
Make error message for backend test validation more clear
Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
---
M bin/validate-unified-backend-test-filters.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/12620/1
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Usability fixups for the unified backend test executable
This fixes the error messages in bin/validate-unified-backend-test-filters.py
to be clearer. It also modifies the dependency graph so that
"make $TESTNAME" will run validation on the unified backend executable.
Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Reviewed-on: http://gerrit.cloudera.org:8080/12620
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/CMakeLists.txt
M bin/validate-unified-backend-test-filters.py
2 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12620
to look at the new patch set (#2).
Change subject: Make error message for backend test validation more clear
......................................................................
Make error message for backend test validation more clear
Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
---
M bin/validate-unified-backend-test-filters.py
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/12620/2
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py
File bin/validate-unified-backend-test-filters.py:
http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py@77
PS2, Line 77: print("FAILED: The unified backend test executable contains tests that are\n"
: "missing from the CMake test filters specified via the\n"
: "ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt.\n"
: "To fix this, add a pattern in the appropriate CMakeLists.txt to match\n"
: "the following tests:")
There are two different errors.
The first one (above at without_filter != with_filter) is where a test is in the binary but not specified in filters. This description needs to move there.
The second one is where a filter doesn't match anything in the binary (this len(filters_without_tests) > 0 condition here). It might be worth updating this second error as well:
FAILED: Some test filters specified by ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt do not match any tests in the unified backend test executable. This can happen if there is a bogus filter or if some tests are not being included in the test executable (e.g. if a new test file is missing from the test library). The invalid test filters are:
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 20:11:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#4) to the change originally created by Lars Volker. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Usability fixups for the unified backend test executable
This fixes the error messages in bin/validate-unified-backend-test-filters.py
to be clearer. It also modifies the dependency graph so that
"make $TESTNAME" will run validation on the unified backend executable.
Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
---
M be/CMakeLists.txt
M bin/validate-unified-backend-test-filters.py
2 files changed, 15 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/12620/4
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12620
to look at the new patch set (#3).
Change subject: Make error message for backend test validation more clear
......................................................................
Make error message for backend test validation more clear
Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
---
M bin/validate-unified-backend-test-filters.py
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/12620/3
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2272/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 04:21:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 03:27:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3852/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 23:25:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2289/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 01:33:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py
File bin/validate-unified-backend-test-filters.py:
http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py@58
PS1, Line 58: print("FAILED: The unified backend test executable contains tests that are\n"
: " missing from the CMake test filters. Consider adding them in\n"
: " be/src/util/CMakeLists.txt. Missing tests:")
> This is going to spread beyond be/src/util/CMakeLists.txt pretty soon. Mayb
Done
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 06:26:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py
File bin/validate-unified-backend-test-filters.py:
http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py@77
PS2, Line 77: print("FAILED: Some test filters specified by\n"
: " ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in\n"
: " CMakeLists.txt do not match any tests in the unified backend\n"
: " test executable. This can happen if there is a bogus filter or\n"
: " if some tests
> There are two different errors.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 00:20:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 4: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 01:39:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 1:
(1 comment)
Thanks for working on this!
I also need to rework the dependencies. This validation should happen even if you run "make $TESTNAME" (where $TESTNAME is in the unified backend test executable). I will put a change together.
http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py
File bin/validate-unified-backend-test-filters.py:
http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py@58
PS1, Line 58: print("FAILED: The unified backend test executable contains tests that are\n"
: " missing from the CMake test filters. Consider adding them in\n"
: " be/src/util/CMakeLists.txt. Missing tests:")
This is going to spread beyond be/src/util/CMakeLists.txt pretty soon. Maybe something like:
FAILED: The unified backend test executable contains tests that are missing from the CMake test filters specified via the ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt. To fix this, add a pattern in the appropriate CMakeLists.txt to match the following tests:
...
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 04:50:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 06:50:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 23:25:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Usability fixups for the unified backend test executable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Usability fixups for the unified backend test executable
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2287/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 01:06:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make error message for backend test validation more clear
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear
......................................................................
Patch Set 3:
Let's flip this around. I'll do an upload and you can review.
--
To view, visit http://gerrit.cloudera.org:8080/12620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8
Gerrit-Change-Number: 12620
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 00:37:38 +0000
Gerrit-HasComments: No