You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/17 11:31:05 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #455: HDDS-2895.
Generate only the required keytabs for docker based secure tests
elek opened a new pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455
## What changes were proposed in this pull request?
TODO
## What is the link to the Apache JIRA
TODO
## How was this patch tested?
TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#455: HDDS-2895. Generate only the required keytabs for docker based secure
tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#discussion_r367940389
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/docker-compose.yaml
##########
@@ -42,6 +41,8 @@ services:
command: ["/opt/hadoop/bin/ozone","datanode"]
env_file:
- docker-config
+ environment:
+ KERBEROS_KEYTABS: dn
Review comment:
Seems like acceptance test failure is caused by missing `HTTP` keytab on datanode.
```
datanode_1 | 2020-01-17 12:30:34,899 [main] ERROR ozone.HddsDatanodeService: HttpServer failed to start.
...
datanode_1 | Caused by: javax.servlet.ServletException: javax.servlet.ServletException: Keytab does not exist: /etc/security/keytabs/HTTP.keytab
```
```suggestion
KERBEROS_KEYTABS: dn HTTP
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#455: HDDS-2895. Generate only the required keytabs for docker based secure
tests
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#discussion_r368038142
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
##########
@@ -80,12 +80,11 @@ HDFS-SITE.XML_rpc.metrics.percentiles.intervals=60,300
OZONE_DATANODE_SECURE_USER=root
SECURITY_ENABLED=true
KEYTAB_DIR=/etc/security/keytabs
-KERBEROS_KEYTABS=dn om scm HTTP testuser testuser2 s3g
KERBEROS_KEYSTORES=hadoop
KERBEROS_SERVER=kdc
JAVA_HOME=/usr/lib/jvm/jre
JSVC_HOME=/usr/bin
SLEEP_SECONDS=5
KERBEROS_ENABLED=true
-no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
\ No newline at end of file
+no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
Review comment:
should we have recon in the no_proxy list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#455: HDDS-2895. Generate only the required keytabs for docker based secure
tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#discussion_r370117728
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
##########
@@ -80,12 +80,11 @@ HDFS-SITE.XML_rpc.metrics.percentiles.intervals=60,300
OZONE_DATANODE_SECURE_USER=root
SECURITY_ENABLED=true
KEYTAB_DIR=/etc/security/keytabs
-KERBEROS_KEYTABS=dn om scm HTTP testuser testuser2 s3g
KERBEROS_KEYSTORES=hadoop
KERBEROS_SERVER=kdc
JAVA_HOME=/usr/lib/jvm/jre
JSVC_HOME=/usr/bin
SLEEP_SECONDS=5
KERBEROS_ENABLED=true
-no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
\ No newline at end of file
+no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
Review comment:
This was added in another task, only newline at EOF is changed. So I think it should be addressed in a new Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #455: HDDS-2895.
Generate only the required keytabs for docker based secure tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#issuecomment-577683737
Thanks @elek for the contribution and @xiaoyuyao for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #455:
HDDS-2895. Generate only the required keytabs for docker based secure tests
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#discussion_r368224654
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
##########
@@ -80,12 +80,11 @@ HDFS-SITE.XML_rpc.metrics.percentiles.intervals=60,300
OZONE_DATANODE_SECURE_USER=root
SECURITY_ENABLED=true
KEYTAB_DIR=/etc/security/keytabs
-KERBEROS_KEYTABS=dn om scm HTTP testuser testuser2 s3g
KERBEROS_KEYSTORES=hadoop
KERBEROS_SERVER=kdc
JAVA_HOME=/usr/lib/jvm/jre
JSVC_HOME=/usr/bin
SLEEP_SECONDS=5
KERBEROS_ENABLED=true
-no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
\ No newline at end of file
+no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
Review comment:
AFAIK it was added to support the the curl/wget executed by the smoketests. As we have no recon specific acceptance tests (yet, hopefully), it's not immediately required...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #455: HDDS-2895.
Generate only the required keytabs for docker based secure tests
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#455: HDDS-2895. Generate only the required keytabs for docker based secure
tests
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #455: HDDS-2895. Generate only the required keytabs for docker based secure tests
URL: https://github.com/apache/hadoop-ozone/pull/455#discussion_r369149831
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/docker-config
##########
@@ -80,12 +80,11 @@ HDFS-SITE.XML_rpc.metrics.percentiles.intervals=60,300
OZONE_DATANODE_SECURE_USER=root
SECURITY_ENABLED=true
KEYTAB_DIR=/etc/security/keytabs
-KERBEROS_KEYTABS=dn om scm HTTP testuser testuser2 s3g
KERBEROS_KEYSTORES=hadoop
KERBEROS_SERVER=kdc
JAVA_HOME=/usr/lib/jvm/jre
JSVC_HOME=/usr/bin
SLEEP_SECONDS=5
KERBEROS_ENABLED=true
-no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
\ No newline at end of file
+no_proxy=om,scm,s3g,kdc,localhost,127.0.0.1
Review comment:
There is one recon acceptance tests just added recently to catch a regression in HDDS-2897.
See #453 for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org