You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/04/30 08:54:51 UTC

[jira] [Created] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Todd Lipcon created HBASE-5901:
----------------------------------

             Summary: Use union type protobufs instead of class/byte pairs for multi requests
                 Key: HBASE-5901
                 URL: https://issues.apache.org/jira/browse/HBASE-5901
             Project: HBase
          Issue Type: Improvement
          Components: ipc, performance
    Affects Versions: 0.96.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-5901:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)
    
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266197#comment-13266197 ] 

stack commented on HBASE-5901:
------------------------------

@Todd you going to commit? I can otherwise.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266133#comment-13266133 ] 

Jimmy Xiang commented on HBASE-5901:
------------------------------------

+1
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5901:
-------------------------

    Priority: Critical  (was: Major)

+1

Nice.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5901:
-------------------------

    Status: Patch Available  (was: Open)
    
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-5901:
-------------------------------

    Attachment: hbase-5901.txt

This patch dropped cumulative CPU usage by about 10% for a million-record insert.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266202#comment-13266202 ] 

Hadoop QA commented on HBASE-5901:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525223/hbase-5901.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//console

This message is automatically generated.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264710#comment-13264710 ] 

Hadoop QA commented on HBASE-5901:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525044/hbase-5901.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.util.TestHBaseFsck

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1687//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1687//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1687//console

This message is automatically generated.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-5901:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5901:
-------------------------

    Attachment: hbase-5901.txt
    
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266375#comment-13266375 ] 

Hudson commented on HBASE-5901:
-------------------------------

Integrated in HBase-TRUNK-security #189 (See [https://builds.apache.org/job/HBase-TRUNK-security/189/])
    HBASE-5901. Use union type protobufs instead of class/byte pairs for multi requests. (Revision 1332882)

     Result = SUCCESS
todd : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* /hbase/trunk/src/main/protobuf/Client.proto

                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266226#comment-13266226 ] 

Todd Lipcon commented on HBASE-5901:
------------------------------------

I tried the same locally. I'll commit this since it seems the test failures are something else.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266283#comment-13266283 ] 

Hudson commented on HBASE-5901:
-------------------------------

Integrated in HBase-TRUNK #2835 (See [https://builds.apache.org/job/HBase-TRUNK/2835/])
    HBASE-5901. Use union type protobufs instead of class/byte pairs for multi requests. (Revision 1332882)

     Result = SUCCESS
todd : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* /hbase/trunk/src/main/protobuf/Client.proto

                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5901:
-------------------------

    Status: Open  (was: Patch Available)

Retrying.  I tried the failing tests local and they pass for me.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-5901:
-------------------------------

    Attachment: hbase-5901.txt

Patch rebased against trunk (something else conflicted with it)
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents of multi actions. Instead, we should introduce a union type protobuf for the valid actions. This makes the RPCs smaller since they don't need to carry class names, and makes deserialization faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira