You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-users@xalan.apache.org by Brian Minchau <mi...@ca.ibm.com> on 2006/04/05 01:13:07 UTC
Xalan-J JIRA defect review - Tuesday April 4, 2006 from 2:00 to 3:30 pm EDT
- Minutes
SUBJECT: Xalan-J JIRA defect
review - Minutes
WHEN: Tuesday April 4, 2006
from 2:00 to 3:30 pm EDT
INVITEES: Active Apache Xalan
committers
CHAIR: Brian Minchau
WHERE: Teleconference
Phone for Toronto
Area: (***) ***-****
Phone for Others:
(***) ***-****
Conference ID for all:
*****
LAST MEETING WAS ON: Tuesday March
7, 2006
Agenda Outline:
0. Roll call
1. New Issues Opened Since Last
Meeting (to be triaged)
2. Brief Summary of defect arrival
and resolution
3. Round Table discussion
4. Record of open/re-opened issues
====================================
==================================
0. Roll call
Attending:
Brian Minchau
Christine Li
Henry Zongaro
Santiago Pericas-Geertsen
Yash Talwar
====================================
==================================
1. New Issues in Open state Since
Last Meeting (to be triaged)
2279
> Brian to check if the fields are
reset and if the patch applied.
2280 Source Repository link is
broken
> Brian M. to do a hot fix on the
website rather than a full rebuild.
> Yash T. to create a patch with the
real fix, and Brian M. to review
2282 Serializer fails to check if
Transformer is null before getting
ErrorListener from it.
2283 [PATCH] remove needless
synchronization
> No patch, probably a duplicate of
2284
2284 [PATCH] remove needless
synchronization
> Henry Z. agreed to review the
patch.
2285 count function applied to union
as test of node identity is broken
> This Xalan-J interpretive bug has
different breakage than
> This worked for 2.7.0 but has
broken during development.
> Currently the count() function in
the testcase always returns 2 or 3
regardless of what it should
return.
> This is a commonly used way of
testing identity in XSLT 1.0
> The fix for XALANJ-2097 may have
further exposed this problem,
> not that XALANJ-2097 was itself a
regression
2286 count function applied to union
as test of node identity is broken
> This XSLTC bug has a different
breakage than XALANJ-2285
> Henry has a fix for this one and
will attach a patch.
> This worked for 2.7.0 but has
broken during development.
> Currently the count() function in
the testcase always returns 1,
regardless of what it should
return.
> This is a commonly used way of
testing identity in XSLT 1.0
> The fix for XALANJ-2097 may have
further exposed this problem,
> not that XALANJ-2097 was itself a
regression
2287 element-available failed for
the extension which not actually
used
> Henry Z. says that Erin H. has
reproduced this Xalan-J interpretive
problem.
2288 XSLTC redirect has problem with
relative filenames
> Brian M. agreed to look into this
one.
2289 Link to source repository still
points to CVS
> This is a duplicate of 2280
2263
> Xalan-J will pick up the fix in
xml-apis.jar later. Brian M.
to answer in JIRA.
2265
> Henry Z. will check if this is a
valid bug. There are issues
> with text nodes with zero
characters.
2266
> Ilene S. may have been working on
this issue.
====================================
==================================
2. Brief Summary of defect arrival
and resolution
March 2005 2068-2090 : 23 new
issues
April 2005 2091-2111 : 21 new
issues
May 2005 2112-2132 : 21 new
issues
June 2005 2133-2164 : 32 new
issues
July 2005 2165-2176 : 12 new
issues
August 2005 2177-2192 : 16 new
issues
September 2005 2193-2206 : 14 new
issues
October 2005 2207-2222 : 16 new
issues
November 2005 2223-2240 : 18 new
issues
December 2005 2241-2250 : 10 new
issues
January 2006 2251-2264 : 13 new
issues
February 2006 2265-2273 : 8 new
issues (6 of 8 reported by
non-committers)
March 2006 2274-2288 : 12 new
issues (4 of 12 reported by
non-committers)
Previous Open or re-opened issue
backlog:
April 5, 2005: 411
May 3, 2005: 409
June 6, 2005: 421
July 12, 2005: 416
February 7, 2006: 446
March 7, 2006:
April 4, 2006: 458
====================================
==================================
3. Round Table discussion
2108
> In the XSLT 1.0 recommendation, in
section 12.2 on xsl:key it says:
> "It is an error for the value of
the use attribute or the match
attribute
> to contain a VariableReference."
> That is the case for this issue.
So the stylesheet is in error,
> and Xalan should have detected
this error at parse time.
> Later at runtime it throws a null
pointer exception.
>
> Previously Xalan gave the
"expected" result, although the
> correct behavior is to have a
parse time error.
>
> However, in the given testcase one
can execute it correctly,
> it is possible to find the right
order to initialize the variables
> and the keys.
>
> The problem in XSLTC is that that
code to resolve circular
dependancies
> within variables, does not include
keys as part of the same logic.
> In the translet there is a
different handling of varibles for
keys.
>
> The consensus of the committers at
the meeting was that we should
> relax the restriction in 12.2 and
not report the error. More users
> would be upset if we strictly
follow 12.2.
> stricter would probably upset more
users, even if we are following
> 12.2. One needs to resolve
dependencies between global
variables is
> not really different than
resolving varibles within keys.
>
> Santiago P.-G. has a patch. Henry
Z. agreed to review.
> Santiago's patch does not cover
more general casses.
> If you have global variables, one
should ensure that they are
> evaluated in the right order so
that any variable is defined before
> it is used. Sometimes determining
the order can't be done statically
> because two variables might depend
on each other and that might
> be only known at runtime.
>
> This bug is actually a bug that is
not detected at compile time.
<xsl:variable name='x'>
<xsl:if select='{$foo}'>
<copy-of select='{$y}'>
</xsl:if>
</xsl:variable>
<xsl:variable name='y'>
<xsl:if select='{$goo}'>
<copy-of select='{$x}'>
</xsl:if>
</xsl:variable>
> If both '{$foo}' and '{$goo}'
evaluate to true then we have a
circular
reference between global variables,
but only detectable at runtime.
> Santiago's patch will not cover
this runtime case that is not
detectable
2259
> In Internet Explorer, when you
select "View" -> "Text size" you
> can change the size. The buttons
on the left hand side of our
> pages don't increase in size
because they are images.
>
> Is there a way to increase image
sizes in the HTML?
====================================
==================================
4. Record of open/re-opened issues
14
18
19
32
36
47
65
67
77
101
111
121
123
169 - Triaged Oct 15, 2001
203
207
232
238
287
291
306
342
391
403
476
540
566
575 - Triaged October 15, 2001
590
605
656
662
666
667
717
718
722
726
738
739
742
745
757
762
763
781
784
797
801
803
808
816
817
834
838
862
888
889
891
896
909
915
916
917
920
923
927
931
942
953
954
955
962
969
979
984
988
989
990
1001
1007
1028
1029
1042
1043
1065
1072
1074
1080
1081
1083
1084
1086
1087
1089
1097
1102
1104
1117
1122
1125
1127
1139
1143
1151
1160
1164
1168
1183
1184
1189
1194
1205
1208
1219
1229
1240
1241
1243
1260
1263
1264
1281
1286
1290
1296
1308
1316
1317
1319
1324
1326
1334
1335
1339
1344
1345
1347
1348
1352
1353
1357
1361
1363
1364
1369
1371
1372
1384
1385
1401
1402
1406
1408
1410
1433
1434
1443
1444
1446
1447
1462
1463
1468
1470
1473
1474
1477
1482
1485
1491
1492
1499
1500
1502
1508
1511
1522
1534
1536
1546
1547
1549
1562
1565
1574
1575
1576
1577
1601
1608
1618
1621
1625
1628
1630
1638
1629
1650
1651
1652
1661
1669
1671
1673
1676
1683
1685
1686
1688
1689
1694
1695
1698
1701
1718
1719
1725
1733
1742
1748
1752
1753
1764
1766
1767
1769
1770
1773
1774
1781
1784
1785
1787
1788
1790
1791
1793
1795
1798
1802
1804
1807
1808
1812
1813
1819
1821
1823
1825
1826
1827
1828
1831
1839
1841
1846
1847
1848
1850
1851
1855
1856
1862
1867
1868
1872
1875
1880
1883
1884
1889
1890
1898
1899
1900
1901
1902
1905
1906
1908
1911
1913
1919
1921
1927
1928
1929
1930
1931
1932
1933
1936
1939
1945
1949
1950
1951
1952
1953
1957
1958
1959
1960
1961
1962
1968
1969
1972
1973
1974
1975
1976
1983
1984
1987
1991
1992
1995
1996
2000
2001
2010
2014
2020
2022
2024
2028
2031
2032
2039
2050
2056
2057
2061
2062
2063
2067
2071
2072
2078
2088
2091
2092
2094
2100
2106
2107
2108 - Triaged April 4, 2006
2111
2112
2113 - Triaged May 3, 2005
2118
2119
2127 - Triaged February 7, 2006
2130 - Triaged February 7, 2006
2133 - Triaged February 7, 2006
2137
2150
2151
2152
2153
2155
2157 - Triaged February 7, 2006
2160
2165
2166
2168 - Triaged March 7, 2006
2169
2171
2173
2177
2178
2180
2186
2188
2189
2190
2191
2192
2193
2194
2195
2196 - Triaged February 7, 2006
2197
2198
2201
2202
2203
2204
2205 - Triaged February 7, 2006
2206
2208
2209
2210
2211
2215
2216
2219
2221 - Triaged February 7, 2006
2222 - Triaged February 7, 2006
2223
2224 - Triaged February 7, 2006
2225
2227
2228
2229
2233
2234
2226
2238
2239
2240 - Triaged February 7, 2006
2241
2242
2243 - Triaged February 7, 2006
2244
2246
2247
2248
2252
2253 - Triaged February 7, 2006
2254
2255
2256
2257
2258
2259 - Triaged April 4, 2006
2260
2261
2262
2263 - Triaged April 4, 2006
2264 - Triaged February 7, 2006
2265 - Triaged April 4, 2006
2266 - Triaged April 4, 2006
2268 - Triaged March 7, 2006
2270 - Triaged March 7, 2006
2271 - Triaged March 7, 2006
2274 - Triaged March 7, 2006
2279 - Triaged April 4, 2006
2280 - Triaged April 4, 2006
2282 - Triaged April 4, 2006
2283 - Triaged April 4, 2006
2284 - Triaged April 4, 2006
2285 - Triaged April 4, 2006
2286 - Triaged April 4, 2006
2287 - Triaged April 4, 2006
2288 - Triaged April 4, 2006
2289 - Triaged April 4, 2006