You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/21 06:57:55 UTC

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

nfsantos opened a new pull request, #713:
URL: https://github.com/apache/jackrabbit-oak/pull/713

   Add OOTB support for testing with Elasticsearch 8.3.3 and 8.4.1.  Now it is enough to pass the property -DelasticDockerImageVersion=[8.3.3|8.4.4] to the Maven build.
   
   In more detail: the tests need to install the Elastiknn plugin in the test Elasticsearch container, with a matching version. The plugin is downloaded from GitHub at the start of the tests. To validate that the right plugin was downloaded, the test infrastructure compares the digest of the file with the plugin with an expected digest. This PR adds the digests for versions 8.3.3 and 8.4.1 of the Elastiknn plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jackrabbit-oak] nfsantos commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

Posted by GitBox <gi...@apache.org>.
nfsantos commented on PR #713:
URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253402399

   > Where did you take these digests from?
   
   I take them from a run of the unit tests. I run the tests with a version of the Elastiknn for which I don't have the digest and copy the digest from the error message that shows that the digest did not match with a dummy digest. This is just to make sure the released version of the plugin does not change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jackrabbit-oak] joerghoh commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

Posted by GitBox <gi...@apache.org>.
joerghoh commented on PR #713:
URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253360241

   Where did you take these digests from?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

Posted by GitBox <gi...@apache.org>.
fabriziofortino merged PR #713:
URL: https://github.com/apache/jackrabbit-oak/pull/713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org